From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: master 0883e98 1/3: New functions for getting and setting image properties Date: Mon, 22 Feb 2016 17:37:13 +0100 Message-ID: <8737skitvq.fsf@web.de> References: <20160220070344.25183.28197@vcs.savannah.gnu.org> <87fuwndeme.fsf@gnus.org> <87twl3e2qo.fsf@web.de> <87ziuuiyo5.fsf@gnus.org> <87twl2i8g5.fsf@web.de> <87egc5bk04.fsf@gnus.org> <87h9h0ant0.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456160290 26484 80.91.229.3 (22 Feb 2016 16:58:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Feb 2016 16:58:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 22 17:58:02 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aXto9-0006Yq-7z for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 17:58:01 +0100 Original-Received: from localhost ([::1]:50315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXto8-00059o-RM for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 11:58:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXtU8-0004dh-JS for emacs-devel@gnu.org; Mon, 22 Feb 2016 11:37:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXtU5-0005mr-AI for emacs-devel@gnu.org; Mon, 22 Feb 2016 11:37:20 -0500 Original-Received: from mout.web.de ([212.227.15.14]:51649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXtU5-0005mG-0X for emacs-devel@gnu.org; Mon, 22 Feb 2016 11:37:17 -0500 Original-Received: from drachen.dragon ([88.67.73.84]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0MCZTG-1ag6wa3Aw6-009PAA; Mon, 22 Feb 2016 17:37:14 +0100 In-Reply-To: <87h9h0ant0.fsf@web.de> (Michael Heerdegen's message of "Mon, 22 Feb 2016 14:15:39 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (gnu/linux) X-Provags-ID: V03:K0:eIsLjht+gG9t8w2H2DI6zd2gW9tiYI932HZk18+bEB9jzYvq/va OpkZRWVoMAWnRWiK3Q6bxcoZ9Nk54r/77GOh8V8PxEThDEQged+7O2qPNnDBl5Ce94bOgUm X6Uob4JizIhRawQtcwoP2zg30NvMb9axQKkWRseIvztwGBZ5GzfpmDLtbXHZEGJqemDZmfy RxC5bKn1DWFe40nAZAOGQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Ulg4qJVIC7o=:xljh/4WDSgDAzlRffYiIRa Zu2XigeGg8P2zcXgGSajUh+fNfuZlGDVKg4VuyQSybwL4V3ZtTE9m7HsCTNNoWbnczOh+7mX/ KQGCclAav8+v0zyllNN498ZMM0YPeXnh+brV8PDxQwNDaNZdrpnXO6+KSU/H7e+EVWhdIOsKi kWKq5KCDiZRENEJCyTbieX6kOEAucOMHz/f2uF5KoFCBBCW8H0JpGP4xvuuA2FxCuckQZQkFO o5yNyDsPe3LVSoDR/SwAd2KFH60VmeoE0Po96N6Amxq5sBVsLdmv7rVJncpTLthCt27g0PneE BombN7KrvSCyw30ZH2NXkMEqC5bDwYYT0s8Ia5nUastzaQVBfdDc8GVllFxXrzH9uqgCl4TYk DW5CTMFQVOYvLFeH5KDRy1U/YZiArkhq7RgbNxEe3H4LmeOfPnPyMCPGS1AV+PIXaYuXoWz22 LovLfIFLPgZ0TB84qE9s4hGti/kgMsQaKutB/6whurtGeRjI/IPK1pWX+cP3037U1oyQbiau5 IsjYNrq7gG7UkWDQRcdGik3bxhaWT5UZ+XcjuNREtWaBXIq3HYkyBDX3rRoGYYqUesma6NnV8 q9aJe09K73niTGcMz0F2m+S8nDIyHg0zBsVc9ErBxXQLEki7ZAhOuDTZtdw2+XmBaWqrzQ0hN joyg2hACpTLaksNJENhWFWRX1skSRc7WNqVJnH3wcOfO7C+v5gnMxAUn8kGt+9GZ7C2+A0/TA ilfj+EaYMjC7UceEZAag86PfvQGWNjk1yX40tIFAx2e08sECWD0/cexHnqlgtDaG+IvHYJYo X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.14 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200466 Archived-At: Michael Heerdegen writes: > Looks ok. Nitpick: according to the doc of `gv-define-simple-setter', > to "preserve the semantics of setf" `image--set-property' should either > return the VALUE. Or use > > (declare (gv-setter image--set-property t)) > ^ > > Hmm, this DTRT, though it's not documented in > > (info "(elisp) Declare Form") > > Will file a bug report... Done - see bug#22766: 25.0.91; (info "(elisp) Declare Form"): gv-setter: mention FIX-RETURN arg Stefan suggests to change `image--set-property' to return the VALUE instead of using the undocumented optional second arg of the gv-setter declare form. Michael.