May I do this small change to image-dired now?

May I do this small change to image-dired now?

[Mathias Dahl]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

Hi,

I got some inspiration today to actually "maintain" `image-dired' again :)

I cloned the Git repo and have committed a small local change. Here is what
git show tells me has happened:

==
Author: Mathias Dahl <mathias.dahl@gmail.com>
Date:   Sat Feb 27 14:11:02 2016 +0100

    Try to preserve the current column when using `image-dired-next-line'
and `image-dired-previous-line'.

diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index a8274f5..67b023d 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -1143,7 +1143,8 @@ image."
 (defun image-dired-next-line ()
   "Move to next line and display properties."
   (interactive)
-  (forward-line 1)
+  (let ((goal-column (current-column)))
+    (next-line))
   ;; If we end up in an empty spot, back up to the next thumbnail.
   (if (not (image-dired-image-at-point-p))
       (image-dired-backward-image))
@@ -1155,7 +1156,8 @@ image."
 (defun image-dired-previous-line ()
   "Move to previous line and display properties."
   (interactive)
-  (forward-line -1)
+  (let ((goal-column (current-column)))
+    (previous-line))
   ;; If we end up in an empty spot, back up to the next
   ;; thumbnail. This should only happen if the user deleted a
   ;; thumbnail and did not refresh, so it is not very common. But we
==

I have two questions:

1. If I git push this change, will it end up on the main Emacs branch (or
trunk, Git and VCSes are not my strongest skill...)? I initially cloned the
repo using my username on Savannah according to the guideline on EmacsWiki.
2. Is it a good time to do this now?

Thanks!

/Mathias

[-- Attachment #2: Type: text/html, Size: 2268 bytes --]

Re: May I do this small change to image-dired now?

[Lars Ingebrigtsen]

Mathias Dahl <mathias.dahl@gmail.com> writes:

> 1. If I git push this change, will it end up on the main Emacs branch (or
> trunk, Git and VCSes are not my strongest skill...)? I initially cloned the
> repo using my username on Savannah according to the guideline on EmacsWiki.

Yes, it'll end up on the trunk (which in gitspeak is called "master").

> 2. Is it a good time to do this now?

Yes.  :-)

Whenever I push something, I just write

git pull --rebase && git push

Somebody has always committed something in the meantime, and you can't
push until you've pulled their work, so that shortcut saves you a bit of
typing (and waiting).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: May I do this small change to image-dired now?

[Mathias Dahl]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

>
> > 1. If I git push this change, will it end up on the main Emacs branch (or
> > trunk, Git and VCSes are not my strongest skill...)? I initially cloned
> the
> > repo using my username on Savannah according to the guideline on
> EmacsWiki.
>
> Yes, it'll end up on the trunk (which in gitspeak is called "master").
>
> > 2. Is it a good time to do this now?
>
> Yes.  :-)
>
> Whenever I push something, I just write
>
> git pull --rebase && git push
>
> Somebody has always committed something in the meantime, and you can't
> push until you've pulled their work, so that shortcut saves you a bit of
> typing (and waiting).
>

Thanks, Lars. That seems to have worked well :)

/Mathias

[-- Attachment #2: Type: text/html, Size: 1086 bytes --]