From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "numbchild@gmail.com" <numbchild@gmail.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: ob-lisp.el patch to choose to use SLIME or SLY
Date: Wed, 06 Apr 2016 11:33:42 +0200 [thread overview]
Message-ID: <8737qzdqtl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAL1eYuJbXYEm_W9ypBOWr_kW7gDdbpMQHEzDgMX0Kw=FBmZkvw@mail.gmail.com> (numbchild@gmail.com's message of "Sun, 27 Mar 2016 09:57:22 +0800")
Hello,
"numbchild@gmail.com" <numbchild@gmail.com> writes:
> I original created an package ob-lisp on here:
> https://github.com/stardiviner/ob-lisp
> and add it to MELPA recipe.
> https://github.com/melpa/melpa/pull/3682
>
> The author suggest me to merge this change to Org-mode.
>
> I attached patch in attachment file.
> Hope someone can merge this patch.
Thank you. I have some comments about it.
> [stardiviner] <Hack this world!> GPG key ID: 47C32433
> IRC(freeenode): stardiviner Twitter: @numbchild
> Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
> Blog: http://stardiviner.github.io/
>
> diff --git a/ob-lisp.el b/ob-lisp.el
> index d2cac3d..04df7fb 100644
> --- a/ob-lisp.el
> +++ b/ob-lisp.el
> @@ -1,14 +1,12 @@
> -;;; ob-lisp.el --- org-babel functions for common lisp evaluation with SLY or SLIME.
> +;;; ob-lisp.el --- org-babel functions for common lisp evaluation
You are not using an up-to-date version of the file, since this header
changed in development version. Could you rebase your patch on top of
latest development release?
>
> -;; Copyright (C) 2016-2020 Free Software Foundation, Inc.
> +;; Copyright (C) 2009-2016 Free Software Foundation, Inc.
Ditto.
> -;; Authors: stardiviner <numbchild@gmail.com>
> -;; Maintainer: stardiviner <numbchild@gmail.com>
> -;; Keywords: org babel lisp sly slime
> -;; URL: https://github.com/stardiviner/ob-lisp
> -;; Created: 1th March 2016
> -;; Version: 0.0.1
> -;; Package-Requires: ((org "8"))
> +;; Authors: Joel Boehland
> +;; Eric Schulte
> +;; David T. O'Toole <dto@gnu.org>
> +;; Keywords: literate programming, reproducible research
> +;; Homepage: http://orgmode.org
Ditto. These changes should not appear in the final patch.
>
> ;; This file is part of GNU Emacs.
>
> @@ -27,27 +25,17 @@
>
> ;;; Commentary:
>
> -;;; Support for evaluating Common Lisp code, relies on SLY or SLIME for all eval.
> +;;; support for evaluating common lisp code, relies on slime for all eval
s/slime/SLIME/
>
> ;;; Requirements:
>
> -;; Requires SLY (Sylvester the Cat's Common Lisp IDE) and SLIME
> -;; See:
> -;; - https://github.com/capitaomorte/sly
> -;; - http://common-lisp.net/project/slime/
> +;; Requires SLIME (Superior Lisp Interaction Mode for Emacs.)
> +;; See http://common-lisp.net/project/slime/
>
> ;;; Code:
> (require 'ob)
>
> -(defcustom org-babel-lisp-eval-fn "sly-eval"
> - "The function to be called to evaluate code on the Lisp side."
> - :group 'org-babel
> - :version "24.1"
> - :options '("sly-eval" "slime-eval")
> - :type 'stringp)
Could you mention this removal in etc/ORG-NEWS? This is a user-visible
change.
Also, could you provide an appropriate commit message, e.g.:
--8<---------------cut here---------------start------------->8---
ob-lisp: Drop SLY in favor of SLIME
* lisp/ob-lisp.el (org-babel-expand-body:lisp,
org-babel-execute:lisp): Use SLIME instead of SLY.
(org-babel-lisp-eval-fn): Remove variable.
--8<---------------cut here---------------end--------------->8---
Feel free to add justifications about this change at the end of the
commit message.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2016-04-06 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 1:57 ob-lisp.el patch to choose to use SLIME or SLY numbchild
2016-04-06 9:33 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737qzdqtl.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.