From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#23276: 25.0.92; Crash in auto-revert when file no longer present Date: Mon, 18 Apr 2016 10:24:25 +0200 Message-ID: <8737qjmiiu.fsf@gmx.de> References: <87vb3hgzr1.fsf@gmx.de> <83fuulbcq7.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1460967924 11318 80.91.229.3 (18 Apr 2016 08:25:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 18 Apr 2016 08:25:24 +0000 (UTC) Cc: 23276-done@debbugs.gnu.org, andlind@gmail.com To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 18 10:25:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1as4Ua-0002tx-7c for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Apr 2016 10:25:12 +0200 Original-Received: from localhost ([::1]:32980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as4UZ-0003uv-BY for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Apr 2016 04:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as4UW-0003sP-7C for bug-gnu-emacs@gnu.org; Mon, 18 Apr 2016 04:25:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1as4UQ-00075n-L1 for bug-gnu-emacs@gnu.org; Mon, 18 Apr 2016 04:25:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1as4UQ-00075h-IR for bug-gnu-emacs@gnu.org; Mon, 18 Apr 2016 04:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1as4UQ-0002hE-F0 for bug-gnu-emacs@gnu.org; Mon, 18 Apr 2016 04:25:02 -0400 Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Apr 2016 08:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 23276 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 23276@debbugs.gnu.org, michael.albinus@gmx.de, andlind@gmail.com Original-Received: via spool by 23276-done@debbugs.gnu.org id=D23276.146096787510323 (code D ref 23276); Mon, 18 Apr 2016 08:25:02 +0000 Original-Received: (at 23276-done) by debbugs.gnu.org; 18 Apr 2016 08:24:35 +0000 Original-Received: from localhost ([127.0.0.1]:38882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as4Tz-0002gQ-Fd for submit@debbugs.gnu.org; Mon, 18 Apr 2016 04:24:35 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:61755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1as4Tx-0002gE-Ee for 23276-done@debbugs.gnu.org; Mon, 18 Apr 2016 04:24:33 -0400 Original-Received: from detlef.gmx.de ([87.146.63.124]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MBWIM-1b0MTE298Y-00AVOt; Mon, 18 Apr 2016 10:24:26 +0200 In-Reply-To: (John Wiegley's message of "Sat, 16 Apr 2016 18:54:17 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:92kiB9Q3rPc83mXPLikYKk+jnG+EGqsIB6Pkne6MK7lU0DvnbSm WqVU/ZNHEuCOj/uv4ej0rDwv3s23j+hPLV5FJPj+988wG0+58H8Pecvg//ydC/+0Atf908z Db5SzTyqRrWvhqjvyXABvfOtNvNExVNiOafenk0S3as9jLIzZcQbMBNXcJxbEq+MFkOI+Td 8IjcrxLWAo3OnuHZR2QaA== X-UI-Out-Filterresults: notjunk:1;V01:K0:pugCrTAIsaw=:mpdiuwZC5+FYp+WxdGJ/dI rV8tdAh9LTXQWFdpxKZzlD0f0phndKEEcZzMlp0hIesNWmLmVl7rfszaFgMmRVQdfNhJEsE2s mL9Paj9DyVghaZvIq1Nux5f2gsJNKTfgRwzbvSEq6UjwmCDwuigu8RPv3NqoVdc3au0Ic5v5R bxMEezIDpPnK2RRrIgE37L2L++OHH3Dgx3xIHA8a6Y9OMfz2ujLrQVXEpf39YyCZ+nW/jLkLQ WQU2GUUZyCIsgTgOyOmTZywuYjZGdUxksYnSgGc1zNR8Vhvb6KPRvkxYR4XMbf2jZPhi3Y3wn IRWZpStqSTEL71vlFoa/cqTHMR54MblMkWhuMnnAcPP7qenBD7ZcRGxuyP/vISybXhpO6b3GX P7e4k0KvAm5TXEE1tuMj1+fZyDx0rBWzqqrqB2Q5TfLH6tTffn2FjYoMBqtDnMZLevF6gKcut h77ezBvpd3E9gYHFSNYNiM1ZUZdO2ZGRr8LMr6VBj3OWH4y+9Woig37HBPBLMMxZ5ndcw68b4 FKac4gkME/dG0/8sDnF4/OekxdAk49dVXpJTGPY0Wm7fQ+6b9eM/HhlgBqbxqO3Z3Auu7VwW0 H7SPGFgZVtcqtHmdhFQ2h/LtoKOHftMNIH7JTiQPIqX870ctLaOFR29sczQxI5u/JSYWyz/hC AjKrBeP4XauzyzLE1tLV/fGoTJrj9KN1W9ciFEM2uaynI3TyB/H8j7IWGLndxcWpKdIbMAC3C x+/8apG13klturUoii8LxhJ9e55svJbDGvcWAMligHu2jgAJ8xhyCCJHTecbNSOY7mYcDlTV X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116582 Archived-At: John Wiegley writes: >> And I still am not convinced that deleting a file under auto-revert >> shouldn't erase its buffer. Otherwise, it sounds like just half-auto-revert >> to me. Would we keep the buffer non-empty if the file existed but was empty? > > I would not want it to erase the buffer. Countless have been the times that > I've been working on a project, and an unbridled rm took away code from the > disk which I was very grateful to find was still in a buffer. I have committed the patch as shown recently (plus a comment) to the emacs-25 branch. This is the least invasive change I could imagine, not endangering the release. Closing the bug. Further changes should go to master. I've prepared already a test case for this. And while testing I found another annoyance: autorevert did not restart once a deleted file has reappeared. This I have fixed also in master. The changes in master will be pushed once the emacs-25 branch has been merged next time. Best regards, Michael.