From: Michael Albinus <michael.albinus@gmx.de>
To: John Wiegley <jwiegley@gmail.com>
Cc: 23276-done@debbugs.gnu.org, andlind@gmail.com
Subject: bug#23276: 25.0.92; Crash in auto-revert when file no longer present
Date: Mon, 18 Apr 2016 10:24:25 +0200 [thread overview]
Message-ID: <8737qjmiiu.fsf@gmx.de> (raw)
In-Reply-To: <m2h9f1ov92.fsf@newartisans.com> (John Wiegley's message of "Sat, 16 Apr 2016 18:54:17 -0700")
John Wiegley <jwiegley@gmail.com> writes:
>> And I still am not convinced that deleting a file under auto-revert
>> shouldn't erase its buffer. Otherwise, it sounds like just half-auto-revert
>> to me. Would we keep the buffer non-empty if the file existed but was empty?
>
> I would not want it to erase the buffer. Countless have been the times that
> I've been working on a project, and an unbridled rm took away code from the
> disk which I was very grateful to find was still in a buffer.
I have committed the patch as shown recently (plus a comment) to the
emacs-25 branch. This is the least invasive change I could imagine, not
endangering the release. Closing the bug.
Further changes should go to master. I've prepared already a test case
for this. And while testing I found another annoyance: autorevert did
not restart once a deleted file has reappeared. This I have fixed also
in master.
The changes in master will be pushed once the emacs-25 branch has been
merged next time.
Best regards, Michael.
next prev parent reply other threads:[~2016-04-18 8:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 11:07 bug#23276: 25.0.92; Crash in auto-revert when file no longer present Anders Lindgren
2016-04-12 15:16 ` Eli Zaretskii
2016-04-12 16:14 ` Michael Albinus
2016-04-16 18:44 ` Michael Albinus
2016-04-16 18:55 ` Anders Lindgren
2016-04-16 20:56 ` Michael Albinus
2016-04-16 19:00 ` Eli Zaretskii
2016-04-16 20:35 ` Michael Albinus
2016-04-16 20:56 ` Anders Lindgren
2016-04-16 21:30 ` Michael Albinus
2016-04-17 1:54 ` John Wiegley
2016-04-17 2:39 ` Eli Zaretskii
2016-04-17 2:53 ` John Wiegley
2016-04-17 2:57 ` John Mastro
2016-04-17 8:52 ` Michael Albinus
2016-04-18 8:26 ` Michael Albinus
2016-04-17 13:20 ` Óscar Fuentes
2016-04-17 15:16 ` Eli Zaretskii
2016-04-17 16:01 ` Óscar Fuentes
2016-04-17 16:10 ` Eli Zaretskii
2016-04-18 8:24 ` Michael Albinus [this message]
2020-12-29 20:02 ` bug#23276: autorevert for a deleted dired directory (ref: 23276) Boruch Baum
2020-12-29 20:13 ` Eli Zaretskii
2020-12-29 20:45 ` Boruch Baum
2020-12-29 20:24 ` Drew Adams
2020-12-29 21:18 ` Boruch Baum
2020-12-29 22:07 ` Drew Adams
2022-04-27 14:09 ` bug#23276: 25.0.92; Crash in auto-revert when file no longer present Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737qjmiiu.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=23276-done@debbugs.gnu.org \
--cc=andlind@gmail.com \
--cc=jwiegley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.