From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 18089@debbugs.gnu.org
Subject: bug#18089: 24.4.50; doc string of `delete-selection-helper'
Date: Sat, 30 Apr 2016 00:36:35 +0200 [thread overview]
Message-ID: <8737q4m498.fsf@gnus.org> (raw)
In-Reply-To: <0ef5fe9b-00d1-4005-b3bf-22df85779287@default> (Drew Adams's message of "Wed, 23 Jul 2014 09:45:32 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> 1. Mention of the TYPE value `t' is incorrrect. It should be "non-nil",
> everywhere, based on what the code actually does (and has always done).
Ok; fixed.
> 2. For FUNCTION, it is not true that the return value should be "one of
> the above values" (even if non-nil replaces t). The return value can
> apparently also be another FUNCTION. So the doc string for FUNCTION
> should say that the return value of FUNCTION should be a value
> acceptable as TYPE.
Ditto.
> 3. All of the info in this doc string should be in the doc string of
> `delete-selection-pre-hook', not in the "helper" function.
Perhaps... but it has a link to the helper function, and I think it's
nice that the helper function has this documentation. So no.
> 4. Doc string lines should be no wider than 70 columns (except the
> first).
Fixed.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2016-04-29 22:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 16:45 bug#18089: 24.4.50; doc string of `delete-selection-helper' Drew Adams
2016-04-29 22:36 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737q4m498.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=18089@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.