From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#22295: viper-mode undo bug introduced between Nov 10 and Nov 14 Date: Wed, 18 May 2016 22:42:04 +0100 Message-ID: <8737pfavrn.fsf@russet.org.uk> References: <83vb2h6lfq.fsf@gnu.org> <83r3d56jrg.fsf@gnu.org> <87poso7nf5.fsf@russet.org.uk> <878tzatbte.fsf@russet.org.uk> <87k2it5bgh.fsf@russet.org.uk> <87wpmrvia7.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1463607803 17584 80.91.229.3 (18 May 2016 21:43:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 May 2016 21:43:23 +0000 (UTC) Cc: John Wiegley , 22295@debbugs.gnu.org To: Jim Meyering Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 18 23:43:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b39FH-0006sj-EF for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 May 2016 23:43:11 +0200 Original-Received: from localhost ([::1]:47171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b39FG-0006jE-S0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 May 2016 17:43:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b39F9-0006iE-3l for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 17:43:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b39F8-0000g3-61 for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 17:43:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b39F8-0000fm-1x for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 17:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b39F7-0008Pr-QR for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 17:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 May 2016 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22295 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22295-submit@debbugs.gnu.org id=B22295.146360773932300 (code B ref 22295); Wed, 18 May 2016 21:43:01 +0000 Original-Received: (at 22295) by debbugs.gnu.org; 18 May 2016 21:42:19 +0000 Original-Received: from localhost ([127.0.0.1]:57384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b39ER-0008Ou-2s for submit@debbugs.gnu.org; Wed, 18 May 2016 17:42:19 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:47944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b39EP-0008Oe-Ms for 22295@debbugs.gnu.org; Wed, 18 May 2016 17:42:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:References:Message-ID :Date:In-Reply-To:Subject:Cc:To:From; bh=HQ9g4K+vYlizLlwO9sPU+riM7rKwK6AtBGwOJCRinZs=; b=ShtnBfn7nqynWuRzINB7PCXQI0 SP6IUoy0ym/XIPbuJAB76h3iKUwBo/MvzvdGOSH/bSSUPyjmWDOA3kQTRyuEaCRP2fadXXpKe3eoN d6UiJ6lESqs18C+nraNF4NX8g+S9gJRErEzyvB30UQExWQSxUskoeAn5bqfbgd10U5/UeJHXULv38 JPw8syWY+z2kHpFC902nWq4Y3XjWvyvqWAabHiwxbSHlCTyFLgHt5vnsJgTvQJDJG2Lr98iBwMJSp ZtRuo7VtcNBsn4qp0fE3+32A2cR74FKn2raaiRcZApEJYVTmZkxkGz2kEddX0qe6FOF3BVm3IZwcu w3JET8AQ==; Original-Received: from cpc1-benw10-2-0-cust373.gate.cable.virginm.net ([77.98.219.118]:49641 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1b39EJ-001vZ0-F2; Wed, 18 May 2016 22:42:11 +0100 In-Reply-To: (Jim Meyering's message of "Wed, 18 May 2016 08:58:55 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118428 Archived-At: Jim Meyering writes: > On Wed, May 18, 2016 at 2:15 AM, Phillip Lord > wrote: >> Yeah, I was adding two undo-boundaries to rather than just one. For no >> readily apparent reason I was directly changing the buffer-undo-list, >> rather than calling undo-boundary. >> >> Anyway, that should be fixed. > > Confirmed. > Thanks again for fixing all of that. Let me know if you find anything else. John, this is a reasonably extensive change now -- affecting both simple.el, but also a big rework of viper undo. To Emacs-25 or not to Emacs-25 that is the question? Phil