From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tao Fang Newsgroups: gmane.emacs.bugs Subject: bug#23225: 25.1.50; url-retrieve-synchronously having trouble with some https URLs Date: Sun, 05 Jun 2016 00:17:54 +0800 Message-ID: <8737otyll9.fsf@gmail.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1465057355 22327 80.91.229.3 (4 Jun 2016 16:22:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 Jun 2016 16:22:35 +0000 (UTC) Cc: Alexis , 23225@debbugs.gnu.org To: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 04 18:22:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b9EI3-0006CV-OQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jun 2016 18:19:12 +0200 Original-Received: from localhost ([::1]:33322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9EI2-00057O-T5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Jun 2016 12:19:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9EHx-00057J-Ih for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 12:19:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9EHu-0007lj-Be for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 12:19:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9EHu-0007lS-7C for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 12:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b9EHu-00074k-3o for bug-gnu-emacs@gnu.org; Sat, 04 Jun 2016 12:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tao Fang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jun 2016 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23225-submit@debbugs.gnu.org id=B23225.146505709527143 (code B ref 23225); Sat, 04 Jun 2016 16:19:02 +0000 Original-Received: (at 23225) by debbugs.gnu.org; 4 Jun 2016 16:18:15 +0000 Original-Received: from localhost ([127.0.0.1]:54537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9EH9-00073j-5b for submit@debbugs.gnu.org; Sat, 04 Jun 2016 12:18:15 -0400 Original-Received: from mail-qg0-f54.google.com ([209.85.192.54]:34638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9EH7-00073W-OF for 23225@debbugs.gnu.org; Sat, 04 Jun 2016 12:18:13 -0400 Original-Received: by mail-qg0-f54.google.com with SMTP id p34so25162501qgp.1 for <23225@debbugs.gnu.org>; Sat, 04 Jun 2016 09:18:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uRadWPXXvIGcu4E5hnKpKysDAEZpW4f+kEnKOA3iw1o=; b=ImHGuNxh2bsvFxQVQzFcDKdSb8YGKw6Z+M7rMPlExPR28vqGFgG/sq+RnOnKkZbRFv kANDIFEE/528D3zcSFOC8PtdRURb+WYCouH9GB3fOzKxT429+4ZUZoaal1cAMVnfd+Nq 9culXneeK7lJqirh3036vHRabdDN0LS4ylKOoXAkPjlmhWQipMMrmwF//k9TYUaAorRV JfNG3TJqKRlE/rGyEzJiid5+Ebj8PFuAxG4AaALCxfbngFfTgFLJB5CGZFOXGrEOicFF he70WN5kUw9pTvdrsOd3sgWpsR2wV7WvV9QCi7euaDfTcUMEHUtzCR2CodvhTWAsa9nU SGqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uRadWPXXvIGcu4E5hnKpKysDAEZpW4f+kEnKOA3iw1o=; b=NEWHzFrzvDgdcDe9HlOemJiNQrj/PpCOnE9Xv9jCJ6zErBjCUSWn1fJtx5cdFJcJPe YKwgqdAILX3oEvs23b7tjuyxAJ7k1t4x0X7BF7P5C4L/j7KKoryRw8iwuvShAwxwnClo b7qS8AemlMaOFRfyZHRpxK3u9fNLu1KNIdZ0MijTzX1bt8cQxPVUkQDWTJkamCLms78G V1cgwHCECwtoRB+vBWTRfddLqrm1E15PmUAwRkG7TIgv84H27NldLnxWq1CpPd/Iahfu j1zvWhUt6rihoj9HgQXYAimIGb19oeXOQSzlKku35L6tRgTWRbRe39OjVrS9YYZvLLnj 78ew== X-Gm-Message-State: ALyK8tLt/l/Ht3Ede1gUIPaxKJm8qh27yy9FODsLJwRn8kQPa/Cw5bw+IXs19tRsVqD8Dw== X-Received: by 10.140.147.202 with SMTP id 193mr8355243qht.54.1465057088208; Sat, 04 Jun 2016 09:18:08 -0700 (PDT) Original-Received: from StormPC.yourcompany.com (ec2-52-3-137-119.compute-1.amazonaws.com. [52.3.137.119]) by smtp.gmail.com with ESMTPSA id a23sm3089368qte.26.2016.06.04.09.17.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Jun 2016 09:18:07 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Tue, 05 Apr 2016 19:30:12 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119063 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable joaotavora@gmail.com (Jo=C3=A3o T=C3=A1vora) writes: > The misbehaving propagated silently and I came across this using M-x > package-install RET ... RET, which magically compiles a 0-byte package. I had same problem when using package-install with restricted network connection (or bad network conditions), sometimes I got empty buffer without any error where as it should fail. > I think the protocol for url-retrieve-synchornously could be > revised. Its users seem to expect it to return nil or at least a > non-buffer if something went wrong, but that's clearly not what happened > here. Perhaps it should error. I agree. So I proposed a patch for this: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-url-retrieve-synchronously-signal-error-when-fail.patch >From ff85fd2a421f751626d61b73d6f268d0cc42d702 Mon Sep 17 00:00:00 2001 From: Tao Fang Date: Sat, 4 Jun 2016 23:27:55 +0800 Subject: [PATCH] url-retrieve-synchronously signal error when fail --- lisp/url/url.el | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/lisp/url/url.el b/lisp/url/url.el index 6d710e0..1d49b10 100644 --- a/lisp/url/url.el +++ b/lisp/url/url.el @@ -235,12 +235,14 @@ how long to wait for a response before giving up." (let ((retrieval-done nil) (start-time (current-time)) - (asynch-buffer nil)) + (asynch-buffer nil) + err) (setq asynch-buffer - (url-retrieve url (lambda (&rest ignored) + (url-retrieve url (lambda (status &rest ignored) (url-debug 'retrieval "Synchronous fetching done (%S)" (current-buffer)) (setq retrieval-done t - asynch-buffer (current-buffer))) + asynch-buffer (current-buffer) + err (plist-get status :error))) nil silent inhibit-cookies)) (if (null asynch-buffer) ;; We do not need to do anything, it was a mailto or something @@ -300,6 +302,12 @@ how long to wait for a response before giving up." (delete-process proc)) (setq proc (and (not quit-flag) (get-buffer-process asynch-buffer))))))) + + ;; Before we return, check for error except 'http + (when (and err + (not (eq (cadr err) 'http))) + (signal (car err) (cdr err))) + asynch-buffer))) ;; url-mm-callback called from url-mm, which requires mm-decode. -- 2.8.3 --=-=-=--