From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25410: 26.0.50; Refine an unified diff hunk only if adds lines Date: Tue, 10 Jan 2017 09:22:36 -0500 Message-ID: <8737gr0zbn.fsf@users.sourceforge.net> References: <8737grz0q3.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1484058143 11427 195.159.176.226 (10 Jan 2017 14:22:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Jan 2017 14:22:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 25410@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 10 15:22:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQxJY-0002Q2-Dm for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Jan 2017 15:22:16 +0100 Original-Received: from localhost ([::1]:47610 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQxJc-0002IC-Oz for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Jan 2017 09:22:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQxJP-0002Eu-NI for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 09:22:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQxJK-0008RD-JK for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 09:22:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cQxJK-0008R7-Gc for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 09:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cQxJK-0002h5-8X for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2017 09:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Jan 2017 14:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25410 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25410-submit@debbugs.gnu.org id=B25410.148405810110322 (code B ref 25410); Tue, 10 Jan 2017 14:22:02 +0000 Original-Received: (at 25410) by debbugs.gnu.org; 10 Jan 2017 14:21:41 +0000 Original-Received: from localhost ([127.0.0.1]:48480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQxIy-0002gQ-TV for submit@debbugs.gnu.org; Tue, 10 Jan 2017 09:21:41 -0500 Original-Received: from mail-it0-f50.google.com ([209.85.214.50]:35402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cQxIx-0002gC-MO for 25410@debbugs.gnu.org; Tue, 10 Jan 2017 09:21:39 -0500 Original-Received: by mail-it0-f50.google.com with SMTP id c20so75609657itb.0 for <25410@debbugs.gnu.org>; Tue, 10 Jan 2017 06:21:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qq7F2HrD6g4aNkNmOrGS8wLwpVdv+8fmkcdAMlh1kJo=; b=QzmYa3GD8OaLMVK83mAqRuRqatW1f92EVK+IG2gTitaRLFB0F9EEPgWeNaI3q3umlJ ciJLVdTQeqlzyifNn0/hNPb44yC44TTgcwWGJp4jkcDcN/Sz6+EyBzBJahemTC5Tzu9D BbUeYjtmtQRbay4rKA/AxXr8sQ4aPkapzEod4JhbYxB666YBt5U2RphOjlqQLBRHmxJE ZJLLe1nWuWrp1zlnagouR1sG/+12FQkJ98Ck0ZB152lYXNpfvw7fR18EQUmUinjevW9h /UBD04QSbSqNDVsnc+sSwz0M1PIjc0J+wEMZtmf/NXtm5TYRtCm0QcASXrHFR5EBXjXr yEzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=qq7F2HrD6g4aNkNmOrGS8wLwpVdv+8fmkcdAMlh1kJo=; b=rkhNodFD08WXaBsdUnGyATK9TlAEc1PqLTS7xg5mZftYohOwksDERnMCUviTDJ32Rv k24tfHHQEWx1kNFTonMGsKcofdMuNctKgPseVAvKEcFjQchHbGQHqVcAebgkhljHEXh6 kk1rUikcUn1IxGT8H9VmKfZMjvU+Oth/BaxZSzKEVLBXyY3TVFaG7d6WEu7ZAK8K4JvU eCu20BvDKNBhRagnezsS5gMd1WJXSXe870YL5uV8h49sCo7ApQBidJpXrhVgB1laZEPK iwJWbPJ2BN7+xOrceE4odBZwXiEaT52Ht7AWCk54h2oHBWs2q/fuX0Odm8XzYF3bGay+ 3Zkg== X-Gm-Message-State: AIkVDXJ9DeIZ6ya2hKdJs7oCuCEJ8llN4vIyOXafil+DwPM3soRn9ycFdZZOFbNdzL7hzg== X-Received: by 10.36.66.143 with SMTP id i137mr185376itb.43.1484058094161; Tue, 10 Jan 2017 06:21:34 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id j143sm10524815ita.1.2017.01.10.06.21.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jan 2017 06:21:33 -0800 (PST) In-Reply-To: <8737grz0q3.fsf@gmail.com> (Tino Calancha's message of "Tue, 10 Jan 2017 19:08:20 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127959 Archived-At: Tino Calancha writes: > After deletion of a large file from CVS, a diff shows > a very large hunk with just deleted lines. Then, for unified diffs, a call > to `diff-refine-hunk' on that hunk takes a huge time. > Instead, it's better to first check if the hunk adds new lines: only when > this is true, then proceed with the hunk refinement. What about a diff that adds a very large file? Perhaps we should only refine if there added lines *and* deleted lines?