From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#25525: 25.1.90; add color highlighting to css mode Date: Wed, 25 Jan 2017 16:34:00 -0700 Message-ID: <8737g6hfyv.fsf@tromey.com> References: <87mvefh8br.fsf@tromey.com> <83inp32l50.fsf@gnu.org> <87inp3gigu.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1485387316 31622 195.159.176.226 (25 Jan 2017 23:35:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 25 Jan 2017 23:35:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) Cc: 25525@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 26 00:35:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWX5m-0007KJ-Hq for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Jan 2017 00:35:06 +0100 Original-Received: from localhost ([::1]:35141 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWX5r-0002qG-RT for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jan 2017 18:35:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWX5m-0002op-Oq for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 18:35:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWX5i-0007Bh-R9 for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 18:35:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45727) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cWX5i-0007Bb-Nd for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 18:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cWX5i-00065e-FT for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2017 18:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2017 23:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25525 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25525-submit@debbugs.gnu.org id=B25525.148538726223360 (code B ref 25525); Wed, 25 Jan 2017 23:35:02 +0000 Original-Received: (at 25525) by debbugs.gnu.org; 25 Jan 2017 23:34:22 +0000 Original-Received: from localhost ([127.0.0.1]:43926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cWX54-00064i-MI for submit@debbugs.gnu.org; Wed, 25 Jan 2017 18:34:22 -0500 Original-Received: from gproxy8-pub.mail.unifiedlayer.com ([67.222.33.93]:45224) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1cWX52-00064U-AZ for 25525@debbugs.gnu.org; Wed, 25 Jan 2017 18:34:20 -0500 Original-Received: (qmail 27013 invoked by uid 0); 25 Jan 2017 23:34:09 -0000 Original-Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy8.mail.unifiedlayer.com with SMTP; 25 Jan 2017 23:34:09 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id cna31u00f2f2jeq01na6FJ; Wed, 25 Jan 2017 16:34:07 -0700 X-Authority-Analysis: v=2.1 cv=H75InYoi c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IgFoBzBjUZAA:10 a=zstS-IiYAAAA:8 a=-5DiPzokYJN1ZtRZJ8sA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OcLUZS1pY5zAhCkm7rgsuCpTZZMdh+1ggfg9Yq7UUbg=; b=xCKkPytN5Tf7B9zCNVn9x1lv7C AgR7ScF2Wy8+UdHOAr+7jL6oZzKFYnNx4yS4sIY7MSDGWcWApsQZHCexV27dpF1a7KUHqb50UO7Uo 8KF1PqZ6b+R/kUKtF8w+AR6Zs; Original-Received: from 75-166-101-147.hlrn.qwest.net ([75.166.101.147]:34040 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cWX4m-0006Xl-Fw; Wed, 25 Jan 2017 16:34:04 -0700 X-Attribution: Tom In-Reply-To: <87inp3gigu.fsf@tromey.com> (Tom Tromey's message of "Wed, 25 Jan 2017 10:25:21 -0700") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box522.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.101.147 X-Exim-ID: 1cWX4m-0006Xl-Fw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-101-147.hlrn.qwest.net (bapiya) [75.166.101.147]:34040 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128515 Archived-At: >>>>> "Tom" == Tom Tromey writes: Tom> It seemed simpler to always set the :foreground, but I can experiment Tom> with :distant-foreground instead. I gave this a try. I think the code in this patch works better than :distant-foreground. One case where it is better is the CSS color "purple", aka #800080. In my theme the foreground color is black. My patch picks white as the foreground, but the Emacs chooses not to use a distant-foreground, but rather keep a black foreground. You can compare these two cases by evalling: (progn (insert (propertize "hello\n" 'font-lock-face '(:background "#800080" :foreground "black" :distant-foreground "white"))) (insert (propertize "hello\n" 'font-lock-face '(:background "#800080" :foreground "white")))) I find the latter much more readable. Tom