From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25777: 25.1; [PATCH] `rectangle--pos-cols' should not move point Date: Thu, 02 Mar 2017 21:09:12 -0500 Message-ID: <8737evaz7b.fsf@users.sourceforge.net> References: <1efbacdb-7d86-454d-b0e0-7a783c47b804@default> <87poi4e7mv.fsf@users.sourceforge.net> <877f4beok7.fsf@users.sourceforge.net> <87tw7edi9d.fsf@users.sourceforge.net> <512a3db8-49d0-4802-aecc-2d71049e0b25@default> <87zih4bhhz.fsf@users.sourceforge.net> <2560c8d7-532e-4882-b3d4-3845312d218f@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1488506951 29647 195.159.176.226 (3 Mar 2017 02:09:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Mar 2017 02:09:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 25777@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 03 03:09:05 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjceX-00074t-Bo for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 Mar 2017 03:09:05 +0100 Original-Received: from localhost ([::1]:55661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjced-0007oq-7G for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Mar 2017 21:09:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjceX-0007oZ-R3 for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2017 21:09:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjceU-0002MF-JY for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2017 21:09:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjceU-0002M9-Fd for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2017 21:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cjceU-0002Sz-51 for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2017 21:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Mar 2017 02:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25777-submit@debbugs.gnu.org id=B25777.14885068879416 (code B ref 25777); Fri, 03 Mar 2017 02:09:02 +0000 Original-Received: (at 25777) by debbugs.gnu.org; 3 Mar 2017 02:08:07 +0000 Original-Received: from localhost ([127.0.0.1]:37210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjcdb-0002Ro-K5 for submit@debbugs.gnu.org; Thu, 02 Mar 2017 21:08:07 -0500 Original-Received: from mail-it0-f46.google.com ([209.85.214.46]:38674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjcda-0002RI-1v for 25777@debbugs.gnu.org; Thu, 02 Mar 2017 21:08:06 -0500 Original-Received: by mail-it0-f46.google.com with SMTP id m27so5136368iti.1 for <25777@debbugs.gnu.org>; Thu, 02 Mar 2017 18:08:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Qo2JQ8wm+sXup+U5sr2IEnUmHXsLIwn/HvVGld0wBhE=; b=ND+KXbdda0O9coIo+E02bGP9a5JYTs/sT8o6a+Ei4DSGSnhOwoREl24zYwhWG+S2Nw uujX9Q4oW3Ipfpf8ea04nV2FH1hAxg+ye4VykkbbDjaMYvcqXw++a0uk4DFkAbW09ZuQ vwqxaLqBtM5BKwLJGTzVgv9DVjIl8wiiJOnivky44lYJX8R3LXcQMmTURv2q6bx3Jb4U p+PZMcwvpudjKNHQcLTwHbYqPgqdFxTpIGvPXavXdD5q7jkeXt5vS+k03DkTVvN/FGjO UjBX3lSHIpVaHW/Mim4DQWtR3mRavawtxoKnvZT2Th7SQhrTMYvj9WQGDCKhkub9ncqz EhIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Qo2JQ8wm+sXup+U5sr2IEnUmHXsLIwn/HvVGld0wBhE=; b=bdqh8mk48cCxij9VONQ4cRTTC3Z2PbsuNWGBNfBC3IiMMMm4xVwcUIfLZ1qu55Hy9T M5No1e4i/G93HRSFr7jKufWwdwsjuXqMAKVo2DX+n7GrIglEuLW+FYRU2ZjtxBpoiL0t oEgtHTAcEY5ckECOlms+No3DrdWdhT1ED2kMZJi4LSdUbGCL4kG/AGNFSdiIMcqCkfyc k5BZB2WwsUqjCRBVpkX2I7ttzq/bkwoqrE0OytuBiNAlIEfgGyqEzL9qy3ldFms97HVe wXxN/xFUpu6oukuWMG2B2DcgoTfZyNlsGFwEN0mUByQ709U6jFL50ew9cdApb+5GgaeG sS1w== X-Gm-Message-State: AMke39kDonGp/vycgQzAIcu40OBDqBEubTiRIJ4gKcCCF9u3lb9CyP4wVXcU3y24jweQow== X-Received: by 10.36.23.74 with SMTP id 71mr1316170ith.37.1488506880384; Thu, 02 Mar 2017 18:08:00 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id e62sm4148781ioj.2.2017.03.02.18.07.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Mar 2017 18:07:59 -0800 (PST) In-Reply-To: (Drew Adams's message of "Thu, 2 Mar 2017 10:13:36 -0800 (PST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130078 Archived-At: Drew Adams writes: >> My suggestion, since I think we've both had our say and are >> unlikely to convince one another on the level of principle >> or guideline, is for you to please make the fix. >> >> Since it is you who will kindly make the actual code change >> and commit, you should/can do it however you like. I have >> no problem with that. >> >> But do you really need another patch for that, especially >> since wrapping widely, a single time, is so much simpler? ;-) >> Could you please make the change? Your way is fine by me, >> for this. Thx. > > Here is a possible doc string for the renamed `rectangle-pos-cols': Yeah, the doc string is the tricky part. > > "Return cons (START-COLUMN . END-COLUMN) of columns delimiting a rectangle. I think the first line is too long. > START and END are buffer positions of the rectangle corners. > > Optional argument WINDOW is the window displaying the rectangle. > It defaults to the selected window." > > I'm not sure it is accurate, but I think so. (I'm no expert on this.) And looking at the function body again, I think it's checking some other things, and seems to have some side effects with respect to the current rectangle.