From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#25599: Why edit markers after insert? Date: Wed, 08 Mar 2017 18:39:23 +0100 Message-ID: <8737en1xdg.fsf@linux-m68k.org> References: <28211825-9989-bd18-1f53-891506af9adf@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1488994862 13917 195.159.176.226 (8 Mar 2017 17:41:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Mar 2017 17:41:02 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 25599@debbugs.gnu.org To: nitish chandra Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 08 18:40:56 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clfa0-0002Wd-Vh for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Mar 2017 18:40:53 +0100 Original-Received: from localhost ([::1]:57637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clfa5-000443-Fw for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Mar 2017 12:40:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clfZE-0003bE-LI for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 12:40:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clfZC-0002li-1U for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 12:40:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48396) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1clfZB-0002ld-VJ for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 12:40:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1clfZB-0007pE-Q5 for bug-gnu-emacs@gnu.org; Wed, 08 Mar 2017 12:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Mar 2017 17:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25599-submit@debbugs.gnu.org id=B25599.148899476930037 (code B ref 25599); Wed, 08 Mar 2017 17:40:01 +0000 Original-Received: (at 25599) by debbugs.gnu.org; 8 Mar 2017 17:39:29 +0000 Original-Received: from localhost ([127.0.0.1]:46595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clfYf-0007oO-D9 for submit@debbugs.gnu.org; Wed, 08 Mar 2017 12:39:29 -0500 Original-Received: from mail-out.m-online.net ([212.18.0.10]:59399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clfYc-0007o5-TJ for 25599@debbugs.gnu.org; Wed, 08 Mar 2017 12:39:27 -0500 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3vdgkj3Lwcz3hkcs; Wed, 8 Mar 2017 18:39:25 +0100 (CET) Original-Received: from localhost (dynscan01.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3vdgkh4PB3zvkVH; Wed, 8 Mar 2017 18:39:24 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan01.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id QLq9bI04fA-4; Wed, 8 Mar 2017 18:39:23 +0100 (CET) X-Auth-Info: egvpRyaSBVwApU4rtrgQicucNi69Uk1z92qL4t/FvPy8RHwVufRrkVIpWoWEuyzy Original-Received: from igel.home (ppp-88-217-27-230.dynamic.mnet-online.de [88.217.27.230]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 8 Mar 2017 18:39:23 +0100 (CET) Original-Received: by igel.home (Postfix, from userid 1000) id 0B6DB2C3E28; Wed, 8 Mar 2017 18:39:23 +0100 (CET) X-Yow: It's strange, but I'm only TRULY ALIVE when I'm covered in POLKA DOTS and TACO SAUCE... In-Reply-To: (nitish chandra's message of "Wed, 8 Mar 2017 21:44:59 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130346 Archived-At: On Mär 08 2017, nitish chandra wrote: > In primitive-undo in simple.el, aroud line 2550 (in master) we adjust the > markers after the insertion. > > (dolist (adj valid-marker-adjustments) > (set-marker (car adj) > (- (car adj) (cdr adj)))) > > Why is this needed? Won't insert take care of adjusting the markers? Only marker originally pointing inside the deleted region were recorded here, and this is to make sure they regain their previous position after the reinsertion. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."