From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#26317: 26.0.50; Small incompatibility in ibuffer.el (ibuffer-compile-format) Date: Thu, 30 Mar 2017 20:25:06 -0400 Message-ID: <8737dumgwt.fsf@holos> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490920014 17063 195.159.176.226 (31 Mar 2017 00:26:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 31 Mar 2017 00:26:54 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 26317-done@debbugs.gnu.org To: John Mastro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 31 02:26:49 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctkOu-0003hM-6R for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Mar 2017 02:26:48 +0200 Original-Received: from localhost ([::1]:38209 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctkP0-0007Ta-1h for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 Mar 2017 20:26:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ctkOE-00079v-Vj for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 20:26:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ctkOB-0006WV-1p for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 20:26:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55133) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ctkOA-0006W9-TQ for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 20:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ctkOA-0003yS-F4 for bug-gnu-emacs@gnu.org; Thu, 30 Mar 2017 20:26:02 -0400 Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Mar 2017 00:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 26317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 26317@debbugs.gnu.org, mvoteiza@udel.edu, john.b.mastro@gmail.com Original-Received: via spool by 26317-done@debbugs.gnu.org id=D26317.149091991615209 (code D ref 26317); Fri, 31 Mar 2017 00:26:02 +0000 Original-Received: (at 26317-done) by debbugs.gnu.org; 31 Mar 2017 00:25:16 +0000 Original-Received: from localhost ([127.0.0.1]:53332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctkNQ-0003xE-7f for submit@debbugs.gnu.org; Thu, 30 Mar 2017 20:25:16 -0400 Original-Received: from mail-qk0-f172.google.com ([209.85.220.172]:36723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ctkNN-0003x0-IH for 26317-done@debbugs.gnu.org; Thu, 30 Mar 2017 20:25:13 -0400 Original-Received: by mail-qk0-f172.google.com with SMTP id p22so54618411qka.3 for <26317-done@debbugs.gnu.org>; Thu, 30 Mar 2017 17:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OHHxSa0jdkghL4UKxGVoMeQLuE+odyzbgimRLOFqyTA=; b=bWYJJfqGeENqwNVUBM8zNZnp+XvjbfaoLV+ana5tSDYN9V5e38H78vsFOzxIhBMQwi BOJr7WxAd48b/lVyOfPufVVKZ9+8Pv0qLVU8B7JqnazGAmf1KQh9pXGCoWPboETRtP0V 9TRdYg4T9gjN47JRxP4vk2RvG+PgyeE6rGE70o2X+zRQbRbITDanpzXk3qhhNKgI+fcS S1WihkKxVRAM/tFs+YC4kDoWDCxeWn1b3ITl2wwv8YqC9YQQ9n16GOVrIF99JTyFs4GQ uMSJsMYIV7t0RjLL3zMU9mChBBZdohVKQV//tmSbFKxMRHZ7uOLozNk6nP1ASZgSkTJg r6ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OHHxSa0jdkghL4UKxGVoMeQLuE+odyzbgimRLOFqyTA=; b=RhjbH2Sq9wA+1MtzUylTYDe7IT9WwznppKuROMtWTtvqMjXI+6SyH/ZDQDIRSmY+2/ s+k/9gAqifoyOnXnK1ot4yeGNDjogF4qBWAyjhATkHbsoFPWuY1Zh9SKUk9hFVbsuqvU s0Yxgy9kmzh643xx8VjCci4Iclc0weqSZNuyo/YFl6PuEonMJDE7xXo5/IaZVCRVXhAr g4OsdDd/yaHXMfDBDtW4uJqm91C/Y8Uij98zgyrkmXM0E4NfCS4lTV4tloGjE0AOHEvQ 5ccBQmLBIKj/4IpxZyFwCRx6FayOkwbHm4A1V8DbWhxu4gGKlfCqGlR0u8Rc2OQKb9AO Urxw== X-Gm-Message-State: AFeK/H3o0ITmsyxhnIIIAkByNjtTKF3EAzKMiM9C/mZKQk7F0Edenjbo5tQExNHRqN0c5osx X-Received: by 10.55.64.73 with SMTP id n70mr177471qka.25.1490919908083; Thu, 30 Mar 2017 17:25:08 -0700 (PDT) Original-Received: from holos.localdomain (pool-173-67-40-97.bltmmd.fios.verizon.net. [173.67.40.97]) by smtp.gmail.com with ESMTPSA id n77sm86747qkn.6.2017.03.30.17.25.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2017 17:25:07 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 6E1956611B; Thu, 30 Mar 2017 20:25:06 -0400 (EDT) In-Reply-To: (John Mastro's message of "Thu, 30 Mar 2017 16:15:16 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:131115 Archived-At: John Mastro writes: > John Mastro wrote: >> In commit 7e2a8b1, ibuffer.el was change to use `string-width' in a couple >> places where it previously used `length'. The result is that custom columns >> which can return nil, which worked in Emacs 25, will now cause an error. > > I've attached a patch that fixes this. Rather than touching the calls to > `string-width' directly, it translates nil to the empty string. Either > way restores compatibility with Emacs 25, but translating nil to the > empty string seems preferable in that it saves later code from caring. > > Even though it's a tiny change, I'm not a regular contributor or > particularly familiar with ibuffer's implementation, so any review is > appreciated. My copyright assignment is on file. LGTM. Sorry for breaking it, and thanks for the fix! Applied as eeaa707.