all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Hendrik Tews <hendrik@askra.de>
To: emacs-orgmode@gnu.org
Subject: Re: Bug: right-alignment fails in column view [9.0.7 (release_9.0.7-439-g2906e5 @ /home/tews/src/org-mode/lisp/)]
Date: Mon, 22 May 2017 14:49:11 +0200	[thread overview]
Message-ID: <8737bxjbug.fsf@cert.kernkonzept.com> (raw)
In-Reply-To: <87pof1f6a7.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Mon, 22 May 2017 14:02:56 +0200")

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> The intent of the check is to warn the user that a columns contains
> invalid values. Applying `string-to-number' unconditionally could give
> strange results for example, with {mean,%.2f}.

I do see your point here. I don't use mean, but it is probably
good to warn users about invalid values for such summary types.
If you intend to warn the user, why don't you use display-warning
or something similar?

However, for {+} the default return value of string-to-number
fits pretty well. Aborting with a user-error here seems a bit
over the top for me. Especially, because there is no indication
what entry caused the error.

> There is no point to have a "TODO" or a "XXX" value in a column
> that is summarized with {+;%.2f}.

I believe it makes a lot of sense to have

  :PROPERTIES:
  :Effort: TODO
  :END:

and the old behavior of treating TODO as 0 in such cases seems
perfect to me.

I believe you should also permit users to make {+} summaries,
when they are not yet finished with annotating all items.
Currently also a missing property cases an error. 

Hendrik

  reply	other threads:[~2017-05-22 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 13:28 Bug: right-alignment fails in column view [9.0.7 (release_9.0.7-439-g2906e5 @ /home/tews/src/org-mode/lisp/)] Hendrik Tews
2017-05-20 20:14 ` Nicolas Goaziou
2017-05-22  8:07   ` Hendrik Tews
2017-05-22 12:02     ` Nicolas Goaziou
2017-05-22 12:49       ` Hendrik Tews [this message]
2017-05-22 13:38         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737bxjbug.fsf@cert.kernkonzept.com \
    --to=hendrik@askra.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.