bug#27111: mode-line-position is faulty after b0b02ca7

bug#27111: mode-line-position is faulty after b0b02ca7

[Alex]

Start from emacs -Q:

Hover over the 'All' in the mode-line. Emacs does not show the tooltip.

Click on the 'All' in the mode-line. Emacs does not show the menu.

bug#27111: mode-line-position is faulty after b0b02ca7

[Eli Zaretskii]

> From: Alex <agrambot@gmail.com>
> Date: Sat, 27 May 2017 22:35:12 -0600
> Cc: Alan Mackenzie <acm@muc.de>
> 
> Start from emacs -Q:
> 
> Hover over the 'All' in the mode-line. Emacs does not show the tooltip.
> 
> Click on the 'All' in the mode-line. Emacs does not show the menu.

Not just "All" -- any location indication is no longer
mouse-sensitive.

Alan, could you please take a look?

bug#27111: mode-line-position is faulty after b0b02ca7

[Alan Mackenzie]

Hello, Eli.

On Sun, May 28, 2017 at 17:59:05 +0300, Eli Zaretskii wrote:
> > From: Alex <agrambot@gmail.com>
> > Date: Sat, 27 May 2017 22:35:12 -0600
> > Cc: Alan Mackenzie <acm@muc.de>

> > Start from emacs -Q:

> > Hover over the 'All' in the mode-line. Emacs does not show the tooltip.

> > Click on the 'All' in the mode-line. Emacs does not show the menu.

> Not just "All" -- any location indication is no longer
> mouse-sensitive.

> Alan, could you please take a look?

Yes, it's something causing text properties applied in the mode line
with :propertize either not to be applied, to be discarded, or to be
superseded by the mode line's default text properties.

I'll try and solve it properly in the next few days.

By the way, did you see my proposed patch to CC Mode which would allow
the user to switch between block comments and line comments?

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#27111: mode-line-position is faulty after b0b02ca7

[Eli Zaretskii]

> Date: Mon, 29 May 2017 17:35:33 +0000
> Cc: Alex <agrambot@gmail.com>, 27111@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> > Not just "All" -- any location indication is no longer
> > mouse-sensitive.
> 
> > Alan, could you please take a look?
> 
> Yes, it's something causing text properties applied in the mode line
> with :propertize either not to be applied, to be discarded, or to be
> superseded by the mode line's default text properties.

If that's your problem, you should adhere religiously to the following
principle: make sure each string you put into some mode-line variable
has the same properties on all of its characters.

> By the way, did you see my proposed patch to CC Mode which would allow
> the user to switch between block comments and line comments?

Yes.  I'd like to hear more opinions about the issue raised by Stefan.

bug#27111: mode-line-position is faulty after b0b02ca7

[Alan Mackenzie]

Hello, Alex and Eli.

On Sun, May 28, 2017 at 17:59:05 +0300, Eli Zaretskii wrote:
> > From: Alex <agrambot@gmail.com>
> > Date: Sat, 27 May 2017 22:35:12 -0600
> > Cc: Alan Mackenzie <acm@muc.de>

> > Start from emacs -Q:

> > Hover over the 'All' in the mode-line. Emacs does not show the tooltip.

> > Click on the 'All' in the mode-line. Emacs does not show the menu.

> Not just "All" -- any location indication is no longer
> mouse-sensitive.

> Alan, could you please take a look?o

The problem was I had spuriously quoted elements inside a backquote
structure.  This should be fixed by the following patch.

Alex, just to emphasise, though it's probably not necessary to say,
you'll have to rebuild Emacs, properly to incorporate this patch, since
binding.elc is preloaded.  Please try out this patch and either confirm
to me it's fixed the bug, or tell me what's still wrong.  Thanks for
taking the trouble to report this bug, and thanks in advance for trying
out the patch.  :-)



diff --git a/lisp/bindings.el b/lisp/bindings.el
index 0b4c3bda80..07f3441efd 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -382,14 +382,15 @@ mode-line-percent-position
                  (6 "%q")))
   :version "26.1"
   :group 'mode-line)
+(put 'mode-line-percent-position 'risky-local-variable t)
 
 (defvar mode-line-position
   `((:propertize
      mode-line-percent-position
-     'local-map mode-line-column-line-number-mode-map
-     'mouse-face 'mode-line-highlight
+     local-map ,mode-line-column-line-number-mode-map
+     mouse-face mode-line-highlight
      ;; XXX needs better description
-     'help-echo "Size indication mode\n\
+     help-echo "Size indication mode\n\
 mouse-1: Display Line and Column Mode Menu")
     (size-indication-mode
      (8 ,(propertize


-- 
Alan Mackenzie (Nuremberg, Germany).

bug#27111: mode-line-position is faulty after b0b02ca7

[Alex]

Alan Mackenzie <acm@muc.de> writes:

> Hello, Alex and Eli.
>
> The problem was I had spuriously quoted elements inside a backquote
> structure.  This should be fixed by the following patch.
>
> Alex, just to emphasise, though it's probably not necessary to say,
> you'll have to rebuild Emacs, properly to incorporate this patch, since
> binding.elc is preloaded.  Please try out this patch and either confirm
> to me it's fixed the bug, or tell me what's still wrong.  Thanks for
> taking the trouble to report this bug, and thanks in advance for trying
> out the patch.  :-)

It works, thanks.

bug#27111: mode-line-position is faulty after b0b02ca7

[Alan Mackenzie]

Hello, Alex.

On Mon, May 29, 2017 at 22:03:15 -0600, Alex wrote:
> Alan Mackenzie <acm@muc.de> writes:

[ .... ]

> It works, thanks.

OK, thanks.  I've committed the patch, and I'm closing the bug as fixed.

-- 
Alan Mackenzie (Nuremberg, Germany).