all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: "Stefan-W. Hahn" <stefan.hahn@s-hahn.de>
Cc: 27408@debbugs.gnu.org
Subject: bug#27408: 26.0.50; macro setq-local does not have a debug declaration
Date: Sat, 17 Jun 2017 15:45:46 -0400	[thread overview]
Message-ID: <8737ays8id.fsf@users.sourceforge.net> (raw)
In-Reply-To: <20170617134409.GC7178@seven> (Stefan-W. Hahn's message of "Sat,  17 Jun 2017 15:44:09 +0200")

severity 27408 minor
tags 27408 + confirmed
quit

"Stefan-W. Hahn" <stefan.hahn@s-hahn.de> writes:

> Also I'm not sure it is worth to have a debug declaration for every
> macro, but I think for setq-local it makes sense, see attached patch.

Probably most macros should have a declaration, assuming someone takes
the time to make one (if nobody makes one, I would take that as a sign
it's not important).  A few, like `declare-function', will probably
never really need one.  I haven't looked through the whole list, but I
guess `woman-pop' and `woman-push' should be replaced with plain `pop'
and `push'.

>  (defmacro setq-local (var val)
>    "Set variable VAR to value VAL in current buffer."
>    ;; Can't use backquote here, it's too early in the bootstrap.
> +  (declare (debug symbolp form))
>    (list 'set (list 'make-local-variable (list 'quote var)) val))

I get a compile failure after applying this:

  ELC      ../../emacs-master/lisp/subr.elc
Reloading stale subr.el
Loading /home/npostavs/src/emacs/emacs-master/lisp/subr.el (source)...
Eager macro-expansion failure: (wrong-number-of-arguments (3 . 3) 4)
Eager macro-expansion failure: (wrong-number-of-arguments (3 . 3) 4)

In toplevel form:
../../emacs-master/lisp/subr.el:121:1:Error: Wrong number of arguments: (3 . 3), 4






  reply	other threads:[~2017-06-17 19:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-17 13:44 bug#27408: 26.0.50; macro setq-local does not have a debug declaration Stefan-W. Hahn
2017-06-17 19:45 ` npostavs [this message]
2017-06-18  7:13   ` Stefan-W. Hahn
2017-06-25 17:55     ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737ays8id.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=27408@debbugs.gnu.org \
    --cc=stefan.hahn@s-hahn.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.