From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#27569: delete-selection on yank via popup-menu Date: Tue, 11 Jul 2017 21:12:01 -0400 Message-ID: <8737a2fogu.fsf@users.sourceforge.net> References: <49D47C75-80AE-4F81-8713-D90574DB7CA6@misasa.okayama-u.ac.jp> <87inj9hz4o.fsf@users.sourceforge.net> <20170705.081128.918140452192114950.tkk@misasa.okayama-u.ac.jp> <20170711.165928.1681891806866192564.tkk@misasa.okayama-u.ac.jp> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1499821883 17333 195.159.176.226 (12 Jul 2017 01:11:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Jul 2017 01:11:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 27569@debbugs.gnu.org To: Tak Kunihiro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 12 03:11:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dV6BL-0003jh-0K for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jul 2017 03:11:11 +0200 Original-Received: from localhost ([::1]:49606 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV6BN-00068p-Da for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jul 2017 21:11:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV6BF-00068g-Nn for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 21:11:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dV6BC-0002WJ-IH for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 21:11:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60051) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dV6BC-0002W9-E7 for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 21:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dV6BC-0000Di-5L for bug-gnu-emacs@gnu.org; Tue, 11 Jul 2017 21:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jul 2017 01:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27569 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27569-submit@debbugs.gnu.org id=B27569.1499821839801 (code B ref 27569); Wed, 12 Jul 2017 01:11:02 +0000 Original-Received: (at 27569) by debbugs.gnu.org; 12 Jul 2017 01:10:39 +0000 Original-Received: from localhost ([127.0.0.1]:34495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dV6Ap-0000Cl-1A for submit@debbugs.gnu.org; Tue, 11 Jul 2017 21:10:39 -0400 Original-Received: from mail-it0-f47.google.com ([209.85.214.47]:36773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dV6Al-0000CP-RZ; Tue, 11 Jul 2017 21:10:37 -0400 Original-Received: by mail-it0-f47.google.com with SMTP id m68so4509189ith.1; Tue, 11 Jul 2017 18:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1uBXmLYCHqUZPwDKVAGxFhi6ANY61Lui/Radqhkiknw=; b=F2yBZxW0qe3P0uIIO1I7ismZocB0zrbTUgP/+IRpIxibtKTmjQnMqrO0zZ0paoz0BR BnyANYFQbeFLlqcmaNPBxbpiXPXPDsyPr7ombVJANw+PqMb79lH5D8srXDCg8XptidH1 68K8YwXDWrfznsk2bFBuEe1dKcYy7VuiJ7xGblH+XvhDjh7Fp3IWuhVW91ke5OuJKZRN JAEBEVVTrMD4eT/yQaLaUDmQhHCMOuadvD78+/yPipxvzSU2AorIWIubQ1qu3lyL6EjL LQ6ZnALITzK3hmo+fR4ZPEKl08FKM2DPMVXTKZSruMPook44Y+bdEzIhUXTmpJ3QDmEF 3KGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=1uBXmLYCHqUZPwDKVAGxFhi6ANY61Lui/Radqhkiknw=; b=oWcALbAdivQSePypMuTpcRk6rJ+gmWUsoy47jtq5SgJ/jwZC5WEMJRlcC52Z3mav4A iBe8/1Uc3oXa0GNmuQ0ZbQxIjkvZpNcCT3lmc/EGSDbLYwtmq1aSL5ngpNmHEBMHgDwB cZdidU9mfehqJm9oH34d3IRUnE4vMun9nzaDOCYlDX/y6QrpC7x5ajl2nkWPA1W3kEd6 gt6K2VsPf4aGwlga6Y7INhazV+uHmeH8rE/GljxHW88xuvwVIw6zQFU8kOQz8KJ+7VSV E6eImDTpZ0jSDmmt3SFQSzUQGlO4X1qMfG7I/TlOxoPp+HPElae5NOXW3frI2sCJU20V H/Mw== X-Gm-Message-State: AIVw110FYZXjTtP0Rb629gQRDWdUOGWaBwsmWV1PEUb74r6kmWYkDa6W 3Q1EcLdYXHmRng1V X-Received: by 10.36.245.129 with SMTP id k123mr6233253ith.1.1499821829984; Tue, 11 Jul 2017 18:10:29 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id g198sm8743702itb.3.2017.07.11.18.10.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jul 2017 18:10:28 -0700 (PDT) In-Reply-To: <20170711.165928.1681891806866192564.tkk@misasa.okayama-u.ac.jp> (Tak Kunihiro's message of "Tue, 11 Jul 2017 16:59:28 +0900 (JST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134445 Archived-At: --=-=-= Content-Type: text/plain tags 27569 + patch quit Tak Kunihiro writes: > Could you push to the master? Okay, I'll wait a couple more days and then push the following (I think doing setq on this-command makes more sense than let-binding after all). --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v2-0001-Let-delete-selection-mode-work-with-popup-menu-co.patch Content-Description: patch >From 52c16f83b6781c83676507c165e69aaad0a3b2fd Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Tue, 11 Jul 2017 21:09:10 -0400 Subject: [PATCH v2] Let delete-selection-mode work with popup-menu commands (Bug#27569) * lisp/menu-bar.el (popup-menu): Run `pre-command-hook' with `this-command' set to the selected command. --- lisp/menu-bar.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 9c7bcffbaa..107043b501 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -2360,6 +2360,10 @@ (defun popup-menu (menu &optional position prefix from-menu-bar) ;; `setup-specified-language-environment', for instance, ;; expects this to be set from a menu keymap. (setq last-command-event (car (last event))) + ;; Update `this-command' and run `pre-command-hook' so that + ;; things like `delete-selection-pre-hook' will work correctly. + (setq this-command cmd) + (run-hook 'pre-command-hook) ;; mouse-major-mode-menu was using `command-execute' instead. (call-interactively cmd)))) -- 2.11.1 --=-=-=--