gtkutil.c error

gtkutil.c error

[Colin Baxter]

Hello,

I getting a make error in gtkutil.c

gtkutil.c: In function ‘xg_get_scale’:
gtkutil.c:228:5: warning: implicit declaration of function
‘gtk_widget_get_scale_factor’ [-Wimplicit-function-declaration]

The 'make' fails with output

gtkutil.o: In function `xg_get_scale':
/home/redknight/git/emacs/src/gtkutil.c:228: undefined reference to `gtk_widget_get_scale_factor'
collect2: error: ld returned 1 exit status
make[1]: *** [temacs] Error 1


I'm using 3.2.0-4-686-pae #1 SMP Debian 3.2.89-2 i686 GNU/Linux.

Best wishes,

Colin Baxter.

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8

Re: gtkutil.c error

[Lars Ingebrigtsen]

Colin Baxter <m43cap@yandex.com> writes:

> gtkutil.o: In function `xg_get_scale':
> /home/redknight/git/emacs/src/gtkutil.c:228: undefined reference to
> `gtk_widget_get_scale_factor'
> collect2: error: ld returned 1 exit status
> make[1]: *** [temacs] Error 1

What's your GTK version?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: gtkutil.c error

[Colin Baxter]

Dear Lars,

>>>>> "Lars" == Lars Ingebrigtsen <larsi@gnus.org> writes:

    Lars> What's your GTK version?

GTK+ Version 3.4.2

Sorry, I should have said in my original post.

Colin.

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8

Re: gtkutil.c error

[Lars Ingebrigtsen]

Colin Baxter <m43cap@yandex.com> writes:

>     Lars> What's your GTK version?
>
> GTK+ Version 3.4.2

Odd,

https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-get-scale-factor

claims that that function has existed since version 3.10?  Hm...

Oh!  I guess 3.4 is older than 3.10.  :-)

I've now added a GTK version check to that code and pushed.  Can you see
whether this fixes the compilation issue for you?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: gtkutil.c error

[Colin Baxter]

>>>>> "Lars" == Lars Ingebrigtsen <larsi@gnus.org> writes:

    Lars> Odd,

    Lars> https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-get-scale-factor

    Lars> claims that that function has existed since version 3.10?
    Lars> Hm...

    Lars> Oh!  I guess 3.4 is older than 3.10.  :-)

    Lars> I've now added a GTK version check to that code and pushed.
    Lars> Can you see whether this fixes the compilation issue for you?

Yes, Emacs-26.0.50 now 'makes' successfully for me.

Thank you.

Colin.

-- 
--
Colin Baxter
m43cap@yandex.com
GnuPG fingerprint: 68A8 799C 0230 16E7 BF68  2A27 BBFA 2492 91F5 41C8