From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-orgmode@gnu.org, lists@wilkesley.net
Subject: Re: Bug? Setting #+OPTIONS: title:nil Seems to Be Ignored in HTML Export.
Date: Tue, 01 Aug 2017 10:15:28 +0200 [thread overview]
Message-ID: <87379bu2jj.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFyQvY2s+-SpBROrTCau3hsLuXQHSxg46To4nDz-5xpB+ZxcCQ@mail.gmail.com> (Kaushal Modi's message of "Mon, 31 Jul 2017 18:33:50 +0000")
Hello,
Kaushal Modi <kaushal.modi@gmail.com> writes:
> From e57e9e798dd1a54cae7a633fc67e2f825b967eea Mon Sep 17 00:00:00 2001
> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Mon, 31 Jul 2017 14:30:40 -0400
> Subject: [PATCH] Respect :with-title in ox-html
>
> * lisp/ox-html.el (org-html--build-meta-info): Do not insert <title>
> tag in HTML export if :with-title property is nil. Example: by
> setting #+OPTIONS: title:nil
[...]
> + (when (plist-get info :with-title)
> + (format "<title>%s</title>\n" title))
I would use `and' instead of `when' to stress the fact that we're
interested in the return value. Otherwise, LGTM.
Thank you.
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-08-01 8:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 17:35 Bug? Setting #+OPTIONS: title:nil Seems to Be Ignored in HTML Export lists
2017-07-31 18:24 ` Kaushal Modi
2017-07-31 18:33 ` Kaushal Modi
2017-08-01 8:15 ` Nicolas Goaziou [this message]
2017-08-01 9:51 ` Rasmus
2017-08-01 10:41 ` Kaushal Modi
2017-08-01 11:18 ` Rasmus
2017-08-01 19:41 ` Kaushal Modi
2017-08-01 20:48 ` Rasmus
2017-08-01 20:59 ` Kaushal Modi
2017-08-09 9:56 ` Rasmus
2017-08-09 10:38 ` Rasmus
2017-08-14 20:15 ` Kaushal Modi
2017-08-01 22:03 ` Tim Cross
2017-08-01 21:58 ` Tim Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87379bu2jj.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
--cc=lists@wilkesley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.