From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: Question about test failure on Hydra Date: Wed, 02 Aug 2017 17:27:16 +0200 Message-ID: <87379adm7f.fsf@rosalinde> References: <87efsxexf5.fsf@rosalinde> <83r2wx29w9.fsf@gnu.org> <8760e9eksb.fsf@rosalinde> <83ini91e2o.fsf@gnu.org> <87tw1t7yk5.fsf@rosalinde> <838tj40ymm.fsf@gnu.org> <87shhb7gqt.fsf@rosalinde> <83379b1jqb.fsf@gnu.org> <87efsv71mv.fsf@rosalinde> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1501687660 8879 195.159.176.226 (2 Aug 2017 15:27:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 Aug 2017 15:27:40 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Tino Calancha , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 02 17:27:34 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcvYZ-0001p1-D6 for ged-emacs-devel@m.gmane.org; Wed, 02 Aug 2017 17:27:31 +0200 Original-Received: from localhost ([::1]:48295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcvYd-0006vo-RU for ged-emacs-devel@m.gmane.org; Wed, 02 Aug 2017 11:27:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcvYU-0006vg-FN for emacs-devel@gnu.org; Wed, 02 Aug 2017 11:27:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcvYT-0003gp-Dz for emacs-devel@gnu.org; Wed, 02 Aug 2017 11:27:26 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:62947) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcvYP-0003eh-AY; Wed, 02 Aug 2017 11:27:21 -0400 Original-Received: from rosalinde ([83.135.22.67]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M6wWn-1dQMJE1V1Z-00wi5B; Wed, 02 Aug 2017 17:27:17 +0200 In-Reply-To: <87efsv71mv.fsf@rosalinde> (Stephen Berman's message of "Tue, 01 Aug 2017 17:23:36 +0200") X-Provags-ID: V03:K0:ka3b0QseBZjgnOY/UQt1Yo5hH3Q90cujOSi4yzLZYdLL3HC9AWK GZWW5TI0vjl6MYkTEt8nPRrRCbYPw/g9FIZ/lA5R4l+sbPavqJZ2wKDzKmcnaycNlp0/tPs o4JhB0BUc/M9h1xUM1BcO+wE5bWYVeACRBAnKedJCZSg/Qaf3IKfSqDQ/UEws5RHQmOMyGM aDx0G8RKe7IA65URxTScw== X-UI-Out-Filterresults: notjunk:1;V01:K0:LnYMdQjn6kk=:G/hjJIuGNJbCHlOryQMwbi SloV3b3mNd2yBUUyiFah+7UgdWbzFxr180UHHqIoGiY/d0e1toetkTIVxZRgBbWHCY1lHVTi7 IJBPKBJbdE0XtUvxCKiuoJ1BbFVeImZJhK78xJsmhGqMdLMu+Qccv5mpNyeN6LiHoeQiQ7gtK LGhipeNgWOB3aLpXLWfIpQ368/yFdAawdPshoEYmUWxVGLUB5CiGgqNou8/Ro5S/UXGg74UKR /nos8A5Ndhp20m/xudVT3PEPOZIxFXprV/ZSuLEKJDD1iYKumGEzABdBg9wwrKpJKYXFbIUbB vWPkCJYtBrNs0x0DqQMObS1HLJrmASzX2QwMWrsTQBWKsMdkFh6BWZFOnlYjM08eML9w1jFbe ddGF1Sg3bTbk0IAa7C+VzOG9nnT4B8n02q3ddS0J01xkjrLGOoMhsGBE/CVKIlNuL5AZmbeJk B3hP3TCb8s3CGsmWLD0cIBN8RFcKVpHxBAx0FOINbuHqvEr8CK12puPqjTZ1BgP3SWQ/DD543 q8hKvbZLx3Cbs4tBqno1CctBsqJnmMXvxPzjFgYTeeOiizgiWiHuRl0Cq02W1PtUuZua+7wze 5C2ggsJpu3XEEmoqx2p/v2B1z7UPkrUFHS1l45M6Ch606yZUBxC69TJXrOwrNWZDqQLTutlUZ VqxD7N/btJVVmm57o/2ejTQZuh0jod6UkUNo0mSEX1tsbPiUDSs2e9eTt+n5Mks7T787s4MIz W9ZCcskX8/T1JAe2JjWeQ6hvQXC9NFVsB2c3KOqYg4i/J4jEOzyZjSOM0eZpi4x82Z06kAze X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.17.21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217240 Archived-At: On Tue, 01 Aug 2017 17:23:36 +0200 Stephen Berman wrote: > On Tue, 01 Aug 2017 16:49:16 +0300 Eli Zaretskii wrote: > >>> From: Stephen Berman >>> Cc: emacs-devel@gnu.org >>> Date: Tue, 01 Aug 2017 11:57:14 +0200 >>> >>> On Tue, 01 Aug 2017 06:12:49 +0300 Eli Zaretskii wrote: >>> >>> >> From: Stephen Berman >>> >> Cc: emacs-devel@gnu.org >>> >> Date: Mon, 31 Jul 2017 11:20:10 +0200 >>> >> >>> >> (dired test-dir) reverts an existing Dired buffer, because of setting >>> >> dired-auto-revert-buffer to t. (When I step through the code, it is >>> >> after reverting that point moves to the subdirectory line >>> > >>> > By "the point moves" you mean what dired-restore-positions does? >>> >>> Yes. >> >> Then I'd begin with logging the values saved in POSITIONS that >> dired-restore-positions uses, perhaps the recorded positions are >> sometimes wrong. Then we could take it from there, either by looking >> how the values are recorded or how they are restored. > > In commit c5305ff6 Tino Calancha added more assertions to track point, > so this may already be enough to locate the problem if the test fails in > Hydra again. If it isn't, we can add still more. The test is still failing on Hydra in the same way (cf. the log of this build: https://hydra.nixos.org/build/57876570). I've added messages that give the position values before and after the dired call, during which dired-revert is called, which contains the only calls to dired-save-positions and dired-restore-positions. I also added the messages in two more places before the assertion that fails on Hydra, and for good measure once more after that assertion. The resulting messages (except the one before the dired call) should (and on my test runs are) all be identical, but should differ on Hydra if point is somehow moving. Steve Berman