From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#27890: 26.0.50; describe-font does not use Help buffer history Date: Sun, 06 Aug 2017 07:43:08 -0400 Message-ID: <8737946hwz.fsf@users.sourceforge.net> References: <87ini8b8oz.fsf@lylat> <877eyhwr7q.fsf@lylat> <8760e15ywe.fsf@users.sourceforge.net> <873795wj2a.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1502019734 24530 195.159.176.226 (6 Aug 2017 11:42:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 Aug 2017 11:42:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: 27890@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 06 13:42:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deJwe-00062R-50 for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Aug 2017 13:42:08 +0200 Original-Received: from localhost ([::1]:60932 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deJwj-0002vx-UU for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Aug 2017 07:42:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deJwd-0002vV-NG for bug-gnu-emacs@gnu.org; Sun, 06 Aug 2017 07:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1deJwY-0001Bs-Qt for bug-gnu-emacs@gnu.org; Sun, 06 Aug 2017 07:42:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1deJwY-0001Bl-Nx for bug-gnu-emacs@gnu.org; Sun, 06 Aug 2017 07:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1deJwY-0003gi-Gt for bug-gnu-emacs@gnu.org; Sun, 06 Aug 2017 07:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Aug 2017 11:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27890-submit@debbugs.gnu.org id=B27890.150201969714143 (code B ref 27890); Sun, 06 Aug 2017 11:42:02 +0000 Original-Received: (at 27890) by debbugs.gnu.org; 6 Aug 2017 11:41:37 +0000 Original-Received: from localhost ([127.0.0.1]:44129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deJw9-0003g3-5L for submit@debbugs.gnu.org; Sun, 06 Aug 2017 07:41:37 -0400 Original-Received: from mail-io0-f174.google.com ([209.85.223.174]:35208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deJw7-0003fq-6b for 27890@debbugs.gnu.org; Sun, 06 Aug 2017 07:41:35 -0400 Original-Received: by mail-io0-f174.google.com with SMTP id m88so17935039iod.2 for <27890@debbugs.gnu.org>; Sun, 06 Aug 2017 04:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wnJks0KKUAgNE8pldL3hx+MZoZysG6Z9pNO3HWUMVtY=; b=OVEBdGTeDAgo0uaqYD7aDP4WTctmC6F4ixdRbdtQ2oqGDk9Yv+UDkQhDB6I/EYSgMH 7+dU1s+KYgYg7Jt0XBYWjsmogp/MhBXAxxRmWGW8YlIBELkTnwPffJ/MOXdTek8hfmVJ 3WW1EJeMCQJikEt6PsaDYMcPv0LKf3Eio86uRJmwbUWwkLpov5f7WthC5VH2ZKS2tTXF CeWsaixWFZpzG59URZXZBEG+peQ/wi67nDhLAXQxImYfi0LBcKHIRHgRB54cfYOB1lmH MeNtW27pwOzYt9dlgcbMf1cemz8c1dvUs8pAwoCYz+IVeSwAbFOLv4rYUlwsodutGanD Zxew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=wnJks0KKUAgNE8pldL3hx+MZoZysG6Z9pNO3HWUMVtY=; b=mD44S0O6EpBIR1lfJWBux1cHblz+Tpdfmk4L+VVRZ3P/WJaUvbOh9QesUUQyJqR9Os UHOrL/EYuzNqmPuWRJB/48EaDDftu0RHy0IqS8835q0rd1ckqk6eR23ArGp/3kg3VV8q 8C8IgJckn0vM6rI50bOkL92/4aDhnKFq5CoXJD+LUYp/CRTrJZvT08filmMGU4zWxTfd I6NoPHov0ewp22PzZTtXH9gkqXQFXiHlgPpZY4ybAErOls+i2zngHOVAh+1a/Cw4oDjf 7LfOSFrlzA/abCu1n6/PpMIvxy2H3qHmC8kBzU24o+QZ5YdwHS76KTKrWXKjb4hsNps4 4/9w== X-Gm-Message-State: AHYfb5jva2oK18ZTa9HZrDQ1x78LtXTlGTlJcVUEXBddL4DEZOv6tpST 8DLPoWJUcoATg1UO X-Received: by 10.107.12.70 with SMTP id w67mr9074007ioi.295.1502019689363; Sun, 06 Aug 2017 04:41:29 -0700 (PDT) Original-Received: from zony ([45.2.119.48]) by smtp.googlemail.com with ESMTPSA id y28sm2241550ita.2.2017.08.06.04.41.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Aug 2017 04:41:28 -0700 (PDT) In-Reply-To: <873795wj2a.fsf@lylat> (Alex's message of "Sat, 05 Aug 2017 20:01:33 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135486 Archived-At: Alex writes: > npostavs@users.sourceforge.net writes: > >> Looks fine, personally I wouldn't bother introducing that local >> variable. > > I introduced that variable because the procedure conditionally sets > fontname if it's an empty sequence. As it stands, the procedure would > error without capturing that variable ahead of time due to `length' being > called on a font object. Oops, right. I skimmed too quickly because your patch looked so simple. > I figured this was the simplest way around that problem. Do you have an > easier way in mind? I could perhaps change the setq line to instead set > fontname to (face-attribute 'default :family), which would allow for > removing the local variable safely. No, let's not get bogged down in micro-optimization and just go with what you had originally.