From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers Date: Tue, 19 Sep 2017 08:44:02 -0700 Message-ID: <87377id77h.fsf@ericabrahamsen.net> References: <20170918202953.21378.63492@vcs0.savannah.gnu.org> <20170918202955.5043420AC4@vcs0.savannah.gnu.org> <87ingfcrf6.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505835930 13136 195.159.176.226 (19 Sep 2017 15:45:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Sep 2017 15:45:30 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 19 17:45:21 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duKi6-0002w1-8S for ged-emacs-devel@m.gmane.org; Tue, 19 Sep 2017 17:45:18 +0200 Original-Received: from localhost ([::1]:43655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duKiD-00020C-MG for ged-emacs-devel@m.gmane.org; Tue, 19 Sep 2017 11:45:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duKhD-0001yS-5Z for emacs-devel@gnu.org; Tue, 19 Sep 2017 11:44:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duKh9-00086S-NL for emacs-devel@gnu.org; Tue, 19 Sep 2017 11:44:23 -0400 Original-Received: from [195.159.176.226] (port=48321 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duKh9-00084y-F4 for emacs-devel@gnu.org; Tue, 19 Sep 2017 11:44:19 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1duKgx-0008Pw-14 for emacs-devel@gnu.org; Tue, 19 Sep 2017 17:44:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 26 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:npELtS0OqtM47Y56PI0Bn1IAk6o= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218517 Archived-At: Kaushal Modi writes: > On Tue, Sep 19, 2017 at 9:00 AM Stefan Monnier wrote: > > > This was fallout from 9b980e269, aka bug #28412, where now we prompt for > > buffers that have functions in the `write-contents-functions' hook. > > Ah, I see I was looking at the wrong version of the code, sorry. > So the question becomes: why does " *Code-Fontify*" have a non-nil > write-contents-functions? > > It's because ggtags.el enables the major mode from the actual file in this temp " *Code-Fontify*" buffer by calling (funcall mode) in ggtags-fontify-code. I do think ggtags is doing something weird here. But on the other hand, it does seem better if `save-some-buffers' required `buffer-offer-save' to be explicitly set non-nil, rather than drawing an implicit conclusion from the presence of `write-contents-functions'. Ie maybe I should just revert the change to this function, and make sure to set `buffer-offer-save' to t in my use-case. No one will get surprised by save prompts they didn't ask for. That way I could also remove the buffer name check. WDYT? Eric