From: Gemini Lasswell <gazally@runbox.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 25316@debbugs.gnu.org
Subject: bug#25316: Patch for bug#25316: 26.0.50; Bugs in testcover-reinstrument
Date: Tue, 03 Oct 2017 10:32:55 -0700 [thread overview]
Message-ID: <873770rvaw.fsf@runbox.com> (raw)
In-Reply-To: <87lgkwdzcm.fsf@users.sourceforge.net>
Noam Postavsky writes:
> Overriding the function-definition of edebug-before and edebug-after
> doesn't seem very clean. It would be better to have an
> edebug-before-function which is `funcall'ed I think (I know your patch
> didn't introduce this, it just makes it more obvious. Perhaps it could
> be addressed later).
An advantage to using an overridden function-definition is that it makes
backtraces of instrumented code easier to read.
>> + ((or `(\` ,bq-form) `(\` . ,bq-form))
>
> Isn't only the first of these is needed? (read "`foo") ;=> (\` foo)
Yes, only the first is needed, so I'll fix this in both places.
next prev parent reply other threads:[~2017-10-03 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 0:39 bug#25316: 26.0.50; Bugs in testcover-reinstrument Gemini Lasswell
2017-09-25 22:04 ` bug#25316: Patch for " Gemini Lasswell
2017-09-29 10:05 ` Eli Zaretskii
2017-10-03 19:17 ` Gemini Lasswell
2017-10-04 5:55 ` Eli Zaretskii
2017-09-30 14:40 ` Noam Postavsky
2017-10-03 17:32 ` Gemini Lasswell [this message]
2017-10-08 23:38 ` Gemini Lasswell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873770rvaw.fsf@runbox.com \
--to=gazally@runbox.com \
--cc=25316@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.