From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Newsgroups: gmane.emacs.bugs Subject: bug#28814: [BUMP, PATCH] (26.0.90; When *xref* window is needed, original window-switching intent is lost ) Date: Fri, 27 Oct 2017 00:59:28 +0100 Message-ID: <873765wjdr.fsf@gmail.com> References: <87infjm3p3.fsf@gmail.com> <871slyi3lk.fsf_-_@gmail.com> <87lgk22ryu.fsf@gmail.com> <87fua91vis.fsf@gmail.com> <13af136e-12fb-4e8d-81ff-63424b1e1943@yandex.ru> <83inf38dq2.fsf@gnu.org> <87k1zjs0xa.fsf@gmail.com> <83fua78ce9.fsf@gnu.org> <87a80fvte2.fsf@gmail.com> <83y3nx7tdn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509062419 13960 195.159.176.226 (27 Oct 2017 00:00:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Oct 2017 00:00:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 28814@debbugs.gnu.org, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 27 02:00:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7s4F-0002CM-KI for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Oct 2017 02:00:07 +0200 Original-Received: from localhost ([::1]:55165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7s4L-000131-9s for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Oct 2017 20:00:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7s4F-00012e-ME for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 20:00:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7s4A-0006AV-SZ for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 20:00:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55315) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e7s4A-00069X-P6 for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 20:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e7s4A-00056A-EV for bug-gnu-emacs@gnu.org; Thu, 26 Oct 2017 20:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Oct 2017 00:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28814-submit@debbugs.gnu.org id=B28814.150906238119534 (code B ref 28814); Fri, 27 Oct 2017 00:00:02 +0000 Original-Received: (at 28814) by debbugs.gnu.org; 26 Oct 2017 23:59:41 +0000 Original-Received: from localhost ([127.0.0.1]:35763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7s3p-00054z-DB for submit@debbugs.gnu.org; Thu, 26 Oct 2017 19:59:41 -0400 Original-Received: from mail-wr0-f180.google.com ([209.85.128.180]:50715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7s3m-00054l-1z for 28814@debbugs.gnu.org; Thu, 26 Oct 2017 19:59:38 -0400 Original-Received: by mail-wr0-f180.google.com with SMTP id p96so4666438wrb.7 for <28814@debbugs.gnu.org>; Thu, 26 Oct 2017 16:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=YvHOIiooQLLYFyUMLCRRl3J+No2eXzQXOLfcYFG1swk=; b=fcRmb0JqK9ExBsAVSKTBl4UeLUlQk8VqBft/MmkzPUtB62hV28e8UWUBK08eF1znCQ iaWdcBWhCdk1nhdHeM4wEEr5hLZvqWcNLQK5d7lDOHHsa8MCpogXkyzaoR9j2ax83/5E da4okiyljlCvPNFNV1rYWhvvkFVwXD4BCpK3ArNyMnbn9F9pO6UGsTmX9pxjwCwynidk ZNfCEKzRrH86924NPHl/4H1NUQhB7cQATzzjqFwMwpOWSGs65qgh54LOlYSiOuOIJtW6 7JLxU0Rg/KA0jdQzh0QWHJ3D5DFAAhr8Le2JmFKfkmQqbaWvaLbb/nD0WfiYh2pOPkrJ vxdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=YvHOIiooQLLYFyUMLCRRl3J+No2eXzQXOLfcYFG1swk=; b=IhnDK4cVCPthFrtFbjHfbb8R+C8KLYfoZueqIooB1AQjbnFFFnkD4yUVgDasvtytrw uNhPMykxPmfSn6JhvgkPpwl/u7t54i2fyHdbpPJ8b0rl+Hl0aSySpojOdtR+oCLYNGY6 WOVQxFH7K++ntCt3t5cWwPgLstvdtYTLyLsYAe5pwZAOHkMOVlqAQH9fhfcpPdx5T8IN TsQOdU8DugvUTNnLM9sMBjiTt+vjFiCX4xxp0IFFKxlID+1na0kbBqPcnc6XG2VT3v8E Xd0dDg8Etdc0dhycyf498hOlTylbx8HtK5UPB4Rzze+sg/BjrwEqPd1+1hbvlzqIKDHH HJ7Q== X-Gm-Message-State: AMCzsaWSsBx7aQpt4scyfQLT9x4EqiexEMF7nSnAQFdoWxHwGiFceBGZ UfluN0NZiQ2JGRMQkMoo1cL5ZGP0 X-Google-Smtp-Source: ABhQp+TE2iu8p12e4YiK8sMvAQEPXk0wTFmkmbuSsadkAaRp5UNbPRLEtd/byvXH0WWAvrDRjM2cVA== X-Received: by 10.223.145.165 with SMTP id 34mr5952931wri.140.1509062371892; Thu, 26 Oct 2017 16:59:31 -0700 (PDT) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id v15sm647311wmf.25.2017.10.26.16.59.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Oct 2017 16:59:31 -0700 (PDT) In-Reply-To: <83y3nx7tdn.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 26 Oct 2017 19:42:44 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139043 Archived-At: Eli Zaretskii writes: > A few comments to the documentation: > > . Please proofread the text for UK English spellings (e.g., "honour") > and only one space between sentences. Done. > . I don't understand the reason for such extensive changes in the > manual. Most of them look purely stylistic, and I see no problems > with the original text to justify that. Here are the (minor) problems I detected: - In node "Looking up identifiers" there are is a repeated explanation of what motivates a *xref* buffer (lines 1831 and 1863). I think its clearer if this only happens once, so I merged the two. - When the text in the same node talks about RET, I took that opportunity to mention existing C-o binding and the proposed TAB binding. This adds information. - Finally, I changed "To go back to places @emph{from where} you found the definition" to "Once you are at the definition, you may want to go back to places @{from where}". This is indeed purely stylistic, but I thought it was a less abrupt transition from the preceding paragraph that talks about going to definitions. The change looks larger than it really is because of the paragraph filling, but I did only change the first sentence. - A real problem is that the description for RET in the node "Xref Commands" incorrectly states that RET buries the *xref* buffer, which we know it doesn't. > What did I miss? Nothing, I just thought this improved the manual slightly. Tell me which parts, maybe all, you think I should scrap. (though I do believe updates to the "Xref Commands" node are in order) > I don't see a need for a NEWS entry. If this is a > bugfix, then it doesn't belong there, as we don't describe bugfixes in > NEWS (there are too many to describe). I didn't know that, sorry. Apart from the bugfix there is also the new quit-and-jump behaviour, but maybe also not worth it. Your call.