From: Ted Zlatanov <tzz@lifelogs.com>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 29749@debbugs.gnu.org
Subject: bug#29749: 27.0.50; Fix header value extraction in Gnus registry
Date: Sun, 17 Dec 2017 19:35:45 -0500 [thread overview]
Message-ID: <873748lvoe.fsf@lifelogs.com> (raw)
In-Reply-To: <87tvwqjfvk.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 16 Dec 2017 17:35:27 -0800")
On Sat, 16 Dec 2017 17:35:27 -0800 Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
EA> The Gnus registry extracts some header values from messages using
EA> `gnus-registry-fetch-header-fast'. There are two problems with this:
EA> 1. It is called with its arguments reversed which (by luck) causes it to
EA> always return nil.
EA> 2. If it were called correctly it would raise an error, as it tries to
EA> use `assq' to find a string key in a vector. Maybe `gnus-data-header'
EA> used to return a different value, but so far as I can tell this hasn't
EA> worked for quite some time.
EA> It's a bug, but it's one that hasn't done much harm for a while, so I'm
EA> proposing this for master.
Thank you so much for patching that. I'm happy with your fix.
Ted
next prev parent reply other threads:[~2017-12-18 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 1:35 bug#29749: 27.0.50; Fix header value extraction in Gnus registry Eric Abrahamsen
2017-12-18 0:35 ` Ted Zlatanov [this message]
2017-12-18 18:12 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873748lvoe.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=29749@debbugs.gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.