From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#30186: 27.0.50; Password is not hidden in read-passwd Date: Tue, 23 Jan 2018 23:38:10 +0200 Organization: LINKOV.NET Message-ID: <87372w8ddp.fsf@mail.linkov.net> References: <871sikmd6o.fsf@mail.linkov.net> <83zi57qk2w.fsf@gnu.org> <87bmhm7wbw.fsf@mail.linkov.net> <87y3kp8thj.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1516745090 31867 195.159.176.226 (23 Jan 2018 22:04:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Jan 2018 22:04:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 30186@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 23 23:04:46 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee6gK-0007gv-04 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 23:04:40 +0100 Original-Received: from localhost ([::1]:56450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee6iK-0005KO-GO for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Jan 2018 17:06:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee6hi-00050k-Md for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 17:06:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee6he-0004Mr-Rg for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 17:06:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60434) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ee6he-0004MH-LU for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 17:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ee6he-0001yS-D0 for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2018 17:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jan 2018 22:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30186-submit@debbugs.gnu.org id=B30186.15167451157474 (code B ref 30186); Tue, 23 Jan 2018 22:06:02 +0000 Original-Received: (at 30186) by debbugs.gnu.org; 23 Jan 2018 22:05:15 +0000 Original-Received: from localhost ([127.0.0.1]:40091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee6gt-0001wT-8j for submit@debbugs.gnu.org; Tue, 23 Jan 2018 17:05:15 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:60184 helo=homiemail-a21.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee6gr-0001wE-AD for 30186@debbugs.gnu.org; Tue, 23 Jan 2018 17:05:14 -0500 Original-Received: from homiemail-a21.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a21.g.dreamhost.com (Postfix) with ESMTP id DA8ED1C0064; Tue, 23 Jan 2018 14:05:12 -0800 (PST) Original-Received: from localhost.linkov.net (m91-129-108-180.cust.tele2.ee [91.129.108.180]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a21.g.dreamhost.com (Postfix) with ESMTPSA id D56FF1C0062; Tue, 23 Jan 2018 14:05:11 -0800 (PST) In-Reply-To: <87y3kp8thj.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 22 Jan 2018 23:38:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142451 Archived-At: Hi Alan, Do you agree we could remove the effect of with-silent-modifications around set-text-properties, and leave it only on remove-list-of-text-properties? This will help to fix the reported regression. >>> Anyway, I bisected it for you, to >>> c5e89be20a3feba9c67be6855b1dbdc6d8ae5ce2 > >> Here's the discussion reference that should have been in the commit me= ssage: >> >> http://lists.gnu.org/r/emacs-devel/2015-04/msg00506.html > > I confirm that after removing with-silent-modifications from > remove-yank-excluded-properties, C-y leaves =E2=80=98display=E2=80=99 p= roperties > in the minibuffer. It's =E2=80=98(inhibit-modification-hooks t)=E2=80=99= in > let-bind of with-silent-modifications that prevents read-passwd > from calling hide-chars-fun again to put new =E2=80=98display=E2=80=99 = properties > after set-text-properties removes old ones. So this patch should > fix this issue, but I'm not sure if this is right. > > diff --git a/lisp/subr.el b/lisp/subr.el > index 092850a..8673547 100644 > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -3041,7 +3041,8 @@ remove-yank-excluded-properties > (setq run-start run-end))))) > (with-silent-modifications > (if (eq yank-excluded-properties t) > - (set-text-properties start end nil) > + (let ((inhibit-modification-hooks nil)) > + (set-text-properties start end nil)) > (remove-list-of-text-properties start end yank-excluded-proper= ties))))) > =20 > (defvar yank-undo-function)