bug#16708: 24.3.50; font-lock nadvice mechanism

bug#16708: 24.3.50; font-lock nadvice mechanism

[Nicolas Richard]

Hi,

I suggest to add `add-function' and `advice-add' (which are used instead
of defadvice at some places) to the font-lock in lisp mode, just as
defadvice is.

Perhaps lisp-imenu-generic-expression should be updated too, I don't
know what it is exactly.

e.g.

diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
index db15aea..8fe7095 100644
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -170,7 +170,7 @@ It has `lisp-mode-abbrev-table' as its parent."
                          "ignore-errors" "dotimes" "dolist" "declare"))
               (lisp-errs '("warn" "error" "signal"))
               ;; Elisp constructs.  FIXME: update dynamically from obarray.
-              (el-fdefs '("defadvice" "defalias"
+              (el-fdefs '("defadvice" "add-function" "advice-add" "defalias"
                           "define-derived-mode" "define-minor-mode"
                           "define-generic-mode" "define-global-minor-mode"
                           "define-globalized-minor-mode" "define-skeleton"

-- 
Nico.

bug#16708: 24.3.50; font-lock nadvice mechanism

[Stefan Monnier]

> I suggest to add `add-function' and `advice-add' (which are used instead
> of defadvice at some places) to the font-lock in lisp mode, just as
> defadvice is.

It might be OK for advice-add but I'm not sure it makes sense for
add-function.

> Perhaps lisp-imenu-generic-expression should be updated too, I don't
> know what it is exactly.

No, imenu should point to the "definition site", whereas advice-add does
not define a function, it merely modifies it.


        Stefan

bug#16708: 24.3.50; font-lock nadvice mechanism

[Noam Postavsky]

close 16708
quit

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I suggest to add `add-function' and `advice-add' (which are used instead
>> of defadvice at some places) to the font-lock in lisp mode, just as
>> defadvice is.
>
> It might be OK for advice-add but I'm not sure it makes sense for
> add-function.

Well, since we now highlight all macros, add-function is hightlighted,
but advice-add isn't.  I don't think it's worth special casing it.