From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#16708: 24.3.50; font-lock nadvice mechanism Date: Sun, 28 Jan 2018 20:25:58 -0500 Message-ID: <87372pjw0p.fsf@users.sourceforge.net> References: <87r47b14vp.fsf@yahoo.fr> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1517189127 8146 195.159.176.226 (29 Jan 2018 01:25:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 Jan 2018 01:25:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Nicolas Richard , 16708@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 29 02:25:23 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efyCA-0001C6-6J for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Jan 2018 02:25:14 +0100 Original-Received: from localhost ([::1]:53543 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efyE8-0003b4-VZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jan 2018 20:27:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efyDx-0003Yy-TX for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2018 20:27:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efyDu-0002kP-ON for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2018 20:27:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39112) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efyDu-0002k2-L7 for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2018 20:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1efyDu-00032E-9g for bug-gnu-emacs@gnu.org; Sun, 28 Jan 2018 20:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jan 2018 01:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16708-submit@debbugs.gnu.org id=B16708.151718916811604 (code B ref 16708); Mon, 29 Jan 2018 01:27:02 +0000 Original-Received: (at 16708) by debbugs.gnu.org; 29 Jan 2018 01:26:08 +0000 Original-Received: from localhost ([127.0.0.1]:47009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efyD2-000311-E5 for submit@debbugs.gnu.org; Sun, 28 Jan 2018 20:26:08 -0500 Original-Received: from mail-it0-f54.google.com ([209.85.214.54]:37897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efyD0-00030Q-3B; Sun, 28 Jan 2018 20:26:06 -0500 Original-Received: by mail-it0-f54.google.com with SMTP id w14so7451917itc.3; Sun, 28 Jan 2018 17:26:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SZoP9EAQORhcL5N+P0sPVfX1eucew6HExA8OXBBXYvs=; b=G511F0T3eCuakbr3zHKavPWO3wBFY3Gvcuz5RpKCeTuHJfuVqcSx6qsPfP43Gz+QzJ LKlwzRpn0AJW/WcG0ptSstHrOb/61N5l7dTCDn8WGoEiywBMqYnqwI1zZf9OqeNK/Y6O D/hM3sjssY3d6hldFYWUntIA5/ygHu7Zjj3+Zovnr4Ps2URdx2cKVTqN2vfxJ2yKaxTY UHqavXC4oA036PtuFrtspY6Faa+5E6qB+m+MT1NlZAcdHTPHjHiwB4NuSVBTxULyeJcf Mp4JJOmQgzoMFND+HCYUuyYpogfH5dDTBBaVxWQLUw/oTbPWW6t1zMIt5ksJAtJvK15S OX6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=SZoP9EAQORhcL5N+P0sPVfX1eucew6HExA8OXBBXYvs=; b=U18QYrZRRBvQ3PHMYxr2L4tec+ake+fEuJKBa2J+oBfbW6wCILNxHaC1RiOhNeaBkW 0Ey5F1w4cqGRbsrN9d2BOLy0jPkb1kRWAlhblL8B+KRX2vPk5ITw+UCsNdcPikTZhzQU cgRMPclfv6NFYT3vCevVSWos12F7a358ANlqKQeQGaKBum3aSJjp8B/BsSWydlYfrq5X e700irpNA/3Tjt/F5kcufYQxNpZrA2jiRZ1K+QjOLM/bJl9hN8cuiF68FFsiM0qaPmkp +Xh9YUYgstSEW+JMhu+bpR9eVgGl4a1FOKim4/4d6LWXBWGUU8enUxxYP2HjQB4RPTP/ KtMQ== X-Gm-Message-State: AKwxytdhYe3/3/T6yqLgLSdyhlRH+6v+kVAAaxaUZqrySbZBEmAtUnzs l5IYjzUwXK4A+ILUXEGoLnyvrB4S X-Google-Smtp-Source: AH8x227k69QIb8DlpRqb2L1FZvZtm2ycaDkVjMzs+DYYf/6X+9qBsDmvyjd2IQO31zn0aqW0Le0CJg== X-Received: by 10.36.188.198 with SMTP id n189mr24783450ite.91.1517189160456; Sun, 28 Jan 2018 17:26:00 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id u32sm3457134ioi.29.2018.01.28.17.25.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Jan 2018 17:25:59 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Mon, 10 Feb 2014 11:57:23 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142640 Archived-At: close 16708 quit Stefan Monnier writes: >> I suggest to add `add-function' and `advice-add' (which are used instead >> of defadvice at some places) to the font-lock in lisp mode, just as >> defadvice is. > > It might be OK for advice-add but I'm not sure it makes sense for > add-function. Well, since we now highlight all macros, add-function is hightlighted, but advice-add isn't. I don't think it's worth special casing it.