From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#30594: [PATCH] Add coreutils 'ls' support for tramp adb Date: Sat, 24 Feb 2018 21:56:51 +0100 Message-ID: <87371qqf70.fsf@gmx.de> References: <20180224180640.29490-1-m.othacehe@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519505794 4795 195.159.176.226 (24 Feb 2018 20:56:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Feb 2018 20:56:34 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 30594@debbugs.gnu.org To: Mathieu Othacehe Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 24 21:56:30 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epgrs-0000hl-QC for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Feb 2018 21:56:28 +0100 Original-Received: from localhost ([::1]:51426 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epgtv-0005Eq-70 for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Feb 2018 15:58:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epgtS-00051K-Pt for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2018 15:58:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epgtO-0007jd-Uz for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2018 15:58:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51173) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1epgtO-0007jS-R3 for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2018 15:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1epgtO-00068d-FH for bug-gnu-emacs@gnu.org; Sat, 24 Feb 2018 15:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Feb 2018 20:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30594 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30594-submit@debbugs.gnu.org id=B30594.151950582223517 (code B ref 30594); Sat, 24 Feb 2018 20:58:02 +0000 Original-Received: (at 30594) by debbugs.gnu.org; 24 Feb 2018 20:57:02 +0000 Original-Received: from localhost ([127.0.0.1]:59070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epgsP-00067A-Sa for submit@debbugs.gnu.org; Sat, 24 Feb 2018 15:57:02 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:57107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epgsN-00066w-DU for 30594@debbugs.gnu.org; Sat, 24 Feb 2018 15:56:59 -0500 Original-Received: from detlef.gmx.de ([79.140.122.208]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MHoC5-1esj973vcD-003d0F; Sat, 24 Feb 2018 21:56:53 +0100 In-Reply-To: <20180224180640.29490-1-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Sat, 24 Feb 2018 19:06:40 +0100") X-Provags-ID: V03:K0:N1bB//yJcKUvmsnCDPX1QYDl3/USWPmC6kN80NMzlnmI+5wgnyX YTdcCTGGPe48goRYL8rgelzRfVd0Y7iv9Z1csaYCe0/I90cEgjTXhTMAzLu/cv76otgKM4m AFIZ+y12K47f5AP9d+jNHYpzdmOclXXq8O6IPLN+4e8PtHwSolvLfiTwdNDboPrDLTBnZK3 LgWViwJ0dTtdXiI3j1nWA== X-UI-Out-Filterresults: notjunk:1;V01:K0:O4srdmaK+9I=:taITthamSf85qKtSC/BiDO kmk/hXUC/xGEfvIQXhL4uWUxlszIT56qDKynijYY0GSkFDMxycCdOZgVmEtCHW/cPchzmih5o k3EYDp4r6lBx+F/Ef+6BQO2dlFIX6BXygxjz8fPJ3U/UmKhWoK9GGHgMwEhebibkmK8Tvdy3T E9RWaWlef+RyZ3cH66vFD4uNQ6/HeNSScVG8ZK9q577cd5C/ksXFBYIzZnP9OuujY0sifcBaJ sL1ljr3In8sCaoaHxiqE3mpkjMoM6uRxTSA865lYUEiMK+VTSdQayevkuQYLu4dEO2Qfkgf8W DKOQQrlAE8dnrUSuaCm192GRAOCEF7wrntYv0HxnQjThomyz5lPEJZ8V+pdlgqcoA508iJ7VU mMr5qdajYdz8YMEuVqFQG+r5hsvbS3PJvySSlDmXN6/PPWIu/8v9nz7rCN4oHbeo3zntS7Tqg 3v31gE3ZzCazLtBC7fL8+U2MkemnzSAtD7aez8WqNJG7PDY6pl63rGXCHYKkA9XXMoLlmA5XZ 0BrmSeI7dn2aIir6GqwP8eXYeq/Jlx8ehXeAJIiM3vFy/xagdY4t63gxFZMUFcJstcrYDCPXm dsJdjr+g5UXjlcQ3iIFfs+hGalX9EdMxPWaBhmK5WjooRDo4buazsod0CQKaxws8QfR5f2RV1 JWhhlNlX0cDcZ5mo0skzUGnWbhvMWXLRHhv2MXg3M3wJL483sPhOJVwPHelB9+NphiZYPCo1W RupStDLFGxftqfbBKqOC8zcTvw4a1Sci2VJnvszXrw+UoAagK4gJoIXn2ysILmwhk0dkCmQf X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143643 Archived-At: Mathieu Othacehe writes: Hi Mathieu, > Support some Android derived systems where 'ls' binary is provided by > GNU Coreutils. Thanks for this! I cannot test myself, so I'll trust that it works proper. However, > + ;; Support Android derived systems where "ls" command is provided > + ;; by GNU Coreutils. Force "ls" to print one column and set > + ;; time-style to imitate other "ls" flavours. > + ((tramp-adb-send-command-and-check vec "ls --help | grep coreutils") > + "env COLUMNS=1 ls --time-style=long-iso") I believe it is not future-safe to depend on any string in --help output. The better approach is to test, whether the ls command accepts the --time-style=long-iso argument. Something like ((tramp-adb-send-command-and-check vec "ls --time-style=long-iso /dev/null") Could you pls check, whether it works like this? Best regards, Michael.