From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH 5/6] org-table-sort-lines: Fix case-sensitive sorting
Date: Tue, 13 Mar 2018 09:13:15 +0100
Message-ID: <8737149yw4.fsf@nicolasgoaziou.fr>
References: <20180311154352.16920-1-seb@wirrsal.net>
	<20180311154352.16920-5-seb@wirrsal.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46189)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1evf4u-0004th-EL
	for emacs-orgmode@gnu.org; Tue, 13 Mar 2018 04:14:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1evf4p-0005NG-Gh
	for emacs-orgmode@gnu.org; Tue, 13 Mar 2018 04:14:36 -0400
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:43123)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1evf4p-0005Lk-9t
	for emacs-orgmode@gnu.org; Tue, 13 Mar 2018 04:14:31 -0400
In-Reply-To: <20180311154352.16920-5-seb@wirrsal.net> ("Sebastian
	=?utf-8?Q?Reu=C3=9Fe=22's?=
	message of "Sun, 11 Mar 2018 16:43:51 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Sebastian =?utf-8?Q?Reu=C3=9Fe?= <seb@wirrsal.net>
Cc: emacs-orgmode@gnu.org

Sebastian Reu=C3=9Fe <seb@wirrsal.net> writes:

> * org-table.el (org-table-sort-lines): Fix case sensitive sorting,
> improve docstring.
> * test-org-table.el (test-org-table/sort-lines): Enforce C locale when
> testing alphabetic sorting.
>
> =E2=80=98sort-subr=E2=80=99 ignores =E2=80=98sort-fold-case=E2=80=99 when=
 a predicate is provided. To
> correctly handle case-sensitivity, we now bake it into the predicate.
>
> Since we are now sorting according to the user=E2=80=99s locale, WITH-CASE
> will not make a difference in most instances, since most locales
> always sort case-insensitively (cf. how GNU sort ignores the =E2=80=98-f=
=E2=80=99
> switch).  We now mention this in the function docstring.
>
> In order to meaningfully test case-sensitive sorting, we now enforce
> the C locale in the respective unit test.

Applied. Thank you.