all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nikolaus Rath <Nikolaus@rath.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 28331@debbugs.gnu.org
Subject: bug#28331: [gnus] Articles loose read status on expiry
Date: Sun, 29 Apr 2018 16:13:57 +0100	[thread overview]
Message-ID: <8736ze11vu.fsf@vostro.rath.org> (raw)
In-Reply-To: <87muy9wh25.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Wed, 11 Apr 2018 23:48:18 +0200")

On Apr 11 2018, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Nikolaus Rath <Nikolaus@rath.org> writes:
>
>> When marking an article as read and for expiry, and the expiry target is
>> another group, the article ends up being unread again in the target
>> group.
>>
>> An easy fix is to take `gnus-summary-expire-articles' out of
>> `gnus-summary-prepare-exit-hook', and instead call it explicitly in
>> `gnus-summary-exit' at a later point.
>>
>> However, this results in the article not just being marked read in the
>> target group (as intended), but also still marked for expiry (not
>> good). I could not figure out how to change that.
>>
>> I've observed this with the nnimap backend.
>
> I don't use expiry targets, but this sounds like the right solution
> (only that the expiry mark should be filtered out).  Could you post the
> patch of what you have and I can take a whack at doing the filtering?

"patch" may be exaggerating it a little bit. What I used is

(remove-hook 'gnus-summary-prepare-exit-hook 'gnus-summary-expire-articles)

in my .gnus and

     ;; Remove entries for this group.
     (nnmail-purge-split-history (gnus-group-real-name group))
     ;; Make all changes in this group permanent.
     (unless quit-config
       (gnus-run-hooks 'gnus-exit-group-hook)
       (gnus-summary-update-info))
+    (gnus-summary-expire-articles)
     (gnus-close-group group)
     ;; Make sure where we were, and go to next newsgroup.
     (when (buffer-live-p (get-buffer gnus-group-buffer))
       (set-buffer gnus-group-buffer))
     (unless quit-config

in gnus-summary-exit (gnus-sum.el).



Best,
-Nikolaus

-- 
GPG Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«





      reply	other threads:[~2018-04-29 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-02 14:30 bug#28331: [gnus] Articles loose read status on expiry Nikolaus Rath
2018-04-11 21:48 ` Lars Ingebrigtsen
2018-04-29 15:13   ` Nikolaus Rath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736ze11vu.fsf@vostro.rath.org \
    --to=nikolaus@rath.org \
    --cc=28331@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.