Parsing of todo state log lines

Parsing of todo state log lines

[Michael Brand]

Hi all

There seems to be an inconsistency in parsing. When
org-log-states-order-reversed is nil (which I am new to) and a TODO
with the manually written state log lines

- State "DONE"       from "TODO"       [2018-05-12 Sat]
- State "DONE"       from              [2018-05-13 Sun]
- State "DONE"       from "TODO"       [2018-05-14 Mon]

is changed to DONE the new state log line is expected to go after the
third line but it goes after the first like if the second was missed
by the parser. When the same state log lines are in a habit they are
all recognized for the consistency graph where they appear as a star,
but still the new state log line goes after the first line.

Found in Org release_9.1.13-751-g9dcc522.

Michael

Re: Parsing of todo state log lines

[Nicolas Goaziou]

Hello,

Michael Brand <michael.ch.brand@gmail.com> writes:

> There seems to be an inconsistency in parsing. When
> org-log-states-order-reversed is nil (which I am new to) and a TODO
> with the manually written state log lines
>
> - State "DONE"       from "TODO"       [2018-05-12 Sat]
> - State "DONE"       from              [2018-05-13 Sun]

I think it should be

  - State "DONE"       from ""           [whatever]

according to `org-log-note-headings'.
  
Regards,

-- 
Nicolas Goaziou

Re: Parsing of todo state log lines

[Michael Brand]

Hi Nicolas

On Wed, May 16, 2018 at 9:07 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Michael Brand <michael.ch.brand@gmail.com> writes:
>
>> There seems to be an inconsistency in parsing. When
>> org-log-states-order-reversed is nil (which I am new to) and a TODO
>> with the manually written state log lines
>>
>> - State "DONE"       from "TODO"       [2018-05-12 Sat]
>> - State "DONE"       from              [2018-05-13 Sun]
>
> I think it should be
>
>   - State "DONE"       from ""           [whatever]
>
> according to `org-log-note-headings'.

I don't see this happen: When starting with this (the % and the
ordering of the lines have been edited manually)

- State "DONE"       from "TODO"       [2018-05-15 Tue 10:00]
- State "DONE"       from "%"          [2018-05-15 Tue 10:00]
- State "DONE"       from ""           [2018-05-15 Tue 10:00]
- State "DONE"       from              [2018-05-15 Tue 10:00]

and without todo keyword in the heading the logs change to

- State "DONE"       from "TODO"       [2018-05-15 Tue 10:00]
- State "DONE"       from "%"          [2018-05-15 Tue 10:00]
- State "DONE"       from              [2018-05-16 Wed 21:45]
- State "DONE"       from ""           [2018-05-15 Tue 10:00]
- State "DONE"       from              [2018-05-15 Tue 10:00]

So also "" is not recognized. And the new middle line is produced without "".

Michael

Re: Parsing of todo state log lines

[Nicolas Goaziou]

Hello,

Michael Brand <michael.ch.brand@gmail.com> writes:

> I don't see this happen: When starting with this (the % and the
> ordering of the lines have been edited manually)
>
> - State "DONE"       from "TODO"       [2018-05-15 Tue 10:00]
> - State "DONE"       from "%"          [2018-05-15 Tue 10:00]
> - State "DONE"       from ""           [2018-05-15 Tue 10:00]
> - State "DONE"       from              [2018-05-15 Tue 10:00]
>
> and without todo keyword in the heading the logs change to
>
> - State "DONE"       from "TODO"       [2018-05-15 Tue 10:00]
> - State "DONE"       from "%"          [2018-05-15 Tue 10:00]
> - State "DONE"       from              [2018-05-16 Wed 21:45]
> - State "DONE"       from ""           [2018-05-15 Tue 10:00]
> - State "DONE"       from              [2018-05-15 Tue 10:00]
>
> So also "" is not recognized. And the new middle line is produced
> without "".

You are right. It should be empty, not "". I think I fixed it in maint.

Thank you.

Regards,

-- 
Nicolas Goaziou

Re: Parsing of todo state log lines

[Michael Brand]

Hi

On Wed, May 16, 2018 at 10:08 PM, Nicolas Goaziou
<mail@nicolasgoaziou.fr> wrote:

> You are right. It should be empty, not "". I think I fixed it in maint.

I still get the new log in the middle line with
release_9.1.13-757-g463664b after restarting Emacs. Did you get the
new log after the last line?

Michael

Re: Parsing of todo state log lines

[Nicolas Goaziou]

Michael Brand <michael.ch.brand@gmail.com> writes:

> I still get the new log in the middle line with
> release_9.1.13-757-g463664b after restarting Emacs. Did you get the
> new log after the last line?

I didn't test logging, but `org-skip-over-state-notes' definitely goes
past the three items, so I guess `org-log-beginning' should put point at
the end of the three items, too.

Re: Parsing of todo state log lines

[Michael Brand]

Hi Nicolas

On Wed, May 16, 2018 at 10:42 PM, Nicolas Goaziou
<mail@nicolasgoaziou.fr> wrote:

> I didn't test logging, but `org-skip-over-state-notes' definitely goes
> past the three items, so I guess `org-log-beginning' should put point at
> the end of the three items, too.

Indeed, it works all as expected. Thank you! (Sorry, my fault was that
the invalid example line with "" was not removed yet.)

Michael