From: Noam Postavsky <npostavs@gmail.com>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: 31884@debbugs.gnu.org
Subject: bug#31884: 26.1.50; Wrong icon in gtk tooltips
Date: Wed, 20 Jun 2018 19:47:53 -0400 [thread overview]
Message-ID: <8736xhrpee.fsf@gmail.com> (raw)
In-Reply-To: <CAELgYhdVxAzit_Crw0fegO6B_LTapEzD6CJ9=VMriW_qvRSRfA@mail.gmail.com> (Carlos Pita's message of "Tue, 19 Jun 2018 21:12:23 -0300")
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
Carlos Pita <carlosjosepita@gmail.com> writes:
> It's just that it was so easy that I described it in words: change
> show_all to show :). But ok, here I'm attaching a proper patch.
> Subject: [PATCH 1/2] Remove broken icon from tooltip
Thanks, I checked it out on my gtk build; I don't have quite the same
icon you showed, but it looks like some kind of place holder that
shouldn't be there indeed. The patch gets rid of it, so I guess it's
the right thing.
Have you done copyright assignment for Emacs? Obviously, the patch is
too trivial to require it, but in case you haven't done it we should
mark the commit with "Copyright-paperwork-exempt: yes".
[-- Attachment #2: screenshot of gtk icon using before applying patch --]
[-- Type: image/png, Size: 9235 bytes --]
next prev parent reply other threads:[~2018-06-20 23:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 18:24 bug#31884: 26.1.50; Wrong icon in gtk tooltips Carlos Pita
2018-06-18 19:08 ` Carlos Pita
2018-06-19 1:03 ` Carlos Pita
2018-06-20 0:09 ` Noam Postavsky
2018-06-20 0:12 ` Carlos Pita
2018-06-20 23:47 ` Noam Postavsky [this message]
2018-06-21 0:18 ` Carlos Pita
2018-06-22 0:18 ` Noam Postavsky
2018-06-19 1:15 ` bug#31884: Carlos Pita
2018-06-19 1:17 ` bug#31884: (no subject) Carlos Pita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736xhrpee.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=31884@debbugs.gnu.org \
--cc=carlosjosepita@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.