From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 71a9151: * src/character.c (char_width): Support glyphs with faces. (Bug#32276) Date: Sun, 29 Jul 2018 12:16:22 +0200 Message-ID: <8736w29wjt.fsf@gmail.com> References: <20180727093403.18242.35476@vcs0.savannah.gnu.org> <20180727093405.6D4D521616@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1532859309 16454 195.159.176.226 (29 Jul 2018 10:15:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jul 2018 10:15:09 +0000 (UTC) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 29 12:15:05 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjij9-0004AL-S4 for ged-emacs-devel@m.gmane.org; Sun, 29 Jul 2018 12:15:03 +0200 Original-Received: from localhost ([::1]:47746 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjilG-0008Sr-BZ for ged-emacs-devel@m.gmane.org; Sun, 29 Jul 2018 06:17:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjikY-0008Sm-O3 for emacs-devel@gnu.org; Sun, 29 Jul 2018 06:16:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjikX-0006L3-Ty for emacs-devel@gnu.org; Sun, 29 Jul 2018 06:16:30 -0400 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:42048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjikU-0006JX-4r; Sun, 29 Jul 2018 06:16:26 -0400 Original-Received: by mail-wr1-x42f.google.com with SMTP id e7-v6so9509890wrs.9; Sun, 29 Jul 2018 03:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=FNt7qkhtQy9uznmFAE62CEn+Z6hKQFviyDm3p9TKOsc=; b=HBzMhQkBjStsEL+Tf8o+M+lrOs2Yz+BFV87sMTDhnXi3amHLB9WwLCsujdZ6CG7i9V WI76h3LU2hLhekmJcpmVmnVJulPp8CVy3+99unoGYJa5lnGCOqikdhP7+Uar8mtDUnyv +HehOZehUON0SsPaJJCcoh8WklIu9fUSg8bpmKz4cDK1i6V5dUs1M3ZL0IxI432cAMAZ lQB7tlCCY3GObv8DbAUWqZuIwprmtIFETNB5oOWTHwVvI+Q3MwSpt0cgSmtGSiGJaJTj EC/r07LF6uGmBkLIm7c1Jy1qdY1lJfABZo5VLLQeooqo2E7+mLMP6hAqCc8UQ85GZByq McYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=FNt7qkhtQy9uznmFAE62CEn+Z6hKQFviyDm3p9TKOsc=; b=IjZfwWWyQEFfTk5SZ0XJGhU9rGpovddI2lFsXwPRYdZujDc3OwX4ZgcR2esAtcvg0/ tDLPcqrnriJaktZw2Dpn7nQbg89BnGsuJDRMbGm18K60H5EuRA4Q0ZWspd+nZAt7XPMk pyPcKihVPs6pUYzU3FIMFywWbzpj233YrparH1GQLSZoawe6HDf9uDLEaTZNYTICT5h/ XEqqnqcAZNiNn2fhOzSS1b/O9GpsMRZlQtty0DUioGLjA4qZS+Hdp2Ghbj0u9IQxE/1C jPA2nYlyt+iEnoPKmv9aVT0ZX/7YdoyeqAz7noo3Ax4Cd6U3F57knWfeukTbbkAIwq44 Rk3Q== X-Gm-Message-State: AOUpUlEQwlQ0EK9IQv4RmTHaYMGww+SGVqjb/3oPF1gtpalITCmxOXdT v4Co/Y7FRtHQrl/QBe93t0L6jpUx X-Google-Smtp-Source: AAOMgpfy7Bt/MKP55YmRv287Xcx6WyEaSAv6XZO7kWD+g1rdkyJ/9Nyf5aptskjZ94ssIf/yU9P71A== X-Received: by 2002:adf:ac2d:: with SMTP id v42-v6mr13020677wrc.142.1532859384137; Sun, 29 Jul 2018 03:16:24 -0700 (PDT) Original-Received: from rpluim-ubuntu (vav06-1-78-207-202-134.fbx.proxad.net. [78.207.202.134]) by smtp.gmail.com with ESMTPSA id r1-v6sm9537055wrs.39.2018.07.29.03.16.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Jul 2018 03:16:23 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <20180727093405.6D4D521616@vcs0.savannah.gnu.org> (Eli Zaretskii's message of "Fri, 27 Jul 2018 05:34:05 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227942 Archived-At: eliz@gnu.org (Eli Zaretskii) writes: > @@ -288,13 +289,15 @@ char_width (int c, struct Lisp_Char_Table *dp) > if (VECTORP (disp)) > for (i =3D 0, width =3D 0; i < ASIZE (disp); i++) > { > + int c; > ch =3D AREF (disp, i); > - if (CHARACTERP (ch)) > - { > - int w =3D CHARACTER_WIDTH (XFASTINT (ch)); > - if (INT_ADD_WRAPV (width, w, &width)) > - string_overflow (); > - } > + if (GLYPH_CODE_P (ch)) > + c =3D GLYPH_CODE_CHAR (ch); > + else if (CHARACTERP (ch)) > + c =3D XFASTINT (ch); > + int w =3D CHARACTER_WIDTH (c); > + if (INT_ADD_WRAPV (width, w, &width)) > + string_overflow (); > } > } > return width; With gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)=20 this gives me the following warning: In file included from character.c:34:0: character.c: In function =E2=80=98char_width=E2=80=99: lisp.h:1772:11: warning: =E2=80=98c=E2=80=99 may be used uninitialized in t= his function [-Wmaybe-uninitialized] ? ((a) + (unsigned) 0) op ((b) + (unsigned) 0) \ ^ character.c:292:10: note: =E2=80=98c=E2=80=99 was declared here int c; ^