From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." Date: Fri, 09 Nov 2018 01:13:20 +0100 Message-ID: <8736sbumzj.fsf@web.de> References: <87zhukh1ri.fsf@gmail.com> <87tvksv21u.fsf@web.de> <87efbvrj4c.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1541722330 21521 195.159.176.226 (9 Nov 2018 00:12:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Nov 2018 00:12:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33301@debbugs.gnu.org, Noam Postavsky To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 09 01:12:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKuP8-0005Td-46 for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Nov 2018 01:12:06 +0100 Original-Received: from localhost ([::1]:59580 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKuRD-00044r-O6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2018 19:14:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKuR7-00044a-Mt for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 19:14:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKuR1-0003Zy-52 for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 19:14:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37761) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKuR0-0003ZR-T5 for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 19:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKuR0-0006ZR-IX for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 19:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Nov 2018 00:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33301 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 33301-submit@debbugs.gnu.org id=B33301.154172240825204 (code B ref 33301); Fri, 09 Nov 2018 00:14:02 +0000 Original-Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 00:13:28 +0000 Original-Received: from localhost ([127.0.0.1]:42019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKuQS-0006YR-JN for submit@debbugs.gnu.org; Thu, 08 Nov 2018 19:13:28 -0500 Original-Received: from mout.web.de ([212.227.17.11]:44631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKuQR-0006YD-M7 for 33301@debbugs.gnu.org; Thu, 08 Nov 2018 19:13:28 -0500 Original-Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M7KR8-1fXkJy45n4-00x15t; Fri, 09 Nov 2018 01:13:21 +0100 In-Reply-To: <87efbvrj4c.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 08 Nov 2018 09:52:51 +0000") X-Provags-ID: V03:K1:eUacmPoL4fjZYZBKiizXEFZNCJg62o/Rqls1CMGgXf+IR9S0JGk xOEPM5TGvhz6eXH9QikRFGZgm53S8yTQe1MuzXayxrYmbXa3vnJk8vDUlhIb4KQbNA1QzCv eR/secZ7maJkEw2aG0sKblNFPYZEquIEJoxyPuST0HCFWvysCujnn1+r+i/tKz4BpVvDaz3 y2NFZKHjT2bH5jOOo+pSw== X-UI-Out-Filterresults: notjunk:1;V01:K0:hbkYesMovjM=:hojo1F5nD0O/VelwKjzz0f 7QxztlesmaJFldetbhx/XOYqNXwYfblKp99PVY1WpykX6H5HiurTg+HwA5T8hqX4/oWH+/0+W U8a7LDiOlGNtcemeypAwBCx8a/MVKAI3tk0YgAollgk52lnYBh/RK2fpsheLWHK38OvgplHnk zA9Z7OHNqTCeClU8rpax81sPCZ2KIAKe19Bgoyu7yJVLMeEF1JnmmZQVzCgW9CkdUZzxpKydD 9Sh3y0LjNNyQGO70WvulDHrQcLaHysOXh5ZkjB5Jg2JPWbRtoDg5NNlMwNlm2uAIGzQCwLim8 BxeBvc0pJYkiqzd67FgFKOHR5MAlbL/JaUiBkZLjOp/7v09mlTC2BwNQj1UQtQBHydclFmse7 UiVWdAVpl13pTVgxxJJoyruRbWeHzF1Se7YpxtZ+gA9Gb4TubYMqWBRIAAgHtrkjPutdQAnNH GJvhXIlS6kbxUVYE8chmq5fqFKtqAAuoAbRUhzN9l7Ix0//oLFk8v74kuzTkMYm/T7wc24e9E YcHXOkclSH3gE3mspDsqKjFbiODxMCXwMp3vzKkrQXhAmKneSquEVqCEp4H0uy7sOTf5MOo+7 zktnglJaSwLM5s0YTcSyYNzyUBMDRsycu3L9hUSzPn51QRiz5OvgcaGs135BA5MXIqIvNYp9p 7WVkuyUXkXBQGUURH+ufsc5zZ7S4jUoIBdTvsVGk2WZUDYtTyETea5ZNXrnNjKeb0Pk6vQ9JY 0N2xE94CS7c/PFSf5CxfzMqmLdQhgM+QOHUzGUdxdRQWV3K7TsW/CpkDngI03PkZPSNCSnTe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152186 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Ah, that's unfortunate. Still, coundn't we improve the heuristic by > asking if the "function" has a macro definition? Isn't that closer to > the intended behaviour? > > diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el > index afb7cbd1dd..e7373ece85 100644 > --- a/lisp/emacs-lisp/lisp-mode.el > +++ b/lisp/emacs-lisp/lisp-mode.el > @@ -1104,7 +1104,8 @@ lisp-indent-function > (cond ((or (eq method 'defun) > (and (null method) > (> (length function) 3) > - (string-match "\\`def" function))) > + (string-match "\\`def" function) > + (macrop (intern function)))) > (lisp-indent-defform state indent-point)) > ((integerp method) > (lisp-indent-specform method state If that macro is defined, shouldn't it already be indented correctly without heuristics? Michael.