From: Michael Albinus <michael.albinus@gmx.de>
To: Alex Branham <alex.branham@gmail.com>
Cc: 33309@debbugs.gnu.org
Subject: bug#33309: Add flatten-list?
Date: Mon, 10 Dec 2018 09:44:55 +0100 [thread overview]
Message-ID: <8736r5ojnc.fsf@gmx.de> (raw)
In-Reply-To: <87pnvg7fgg.fsf@gmail.com> (Alex Branham's message of "Wed, 07 Nov 2018 15:19:59 -0600")
Alex Branham <alex.branham@gmail.com> writes:
Hi Alex,
>> 1. Even Common Lisp doesn't bother with one.
>> (And there are lots of Common Lisp
>> functions I'd sooner see added to Emacs.)
>>
>> 2. It's trivial to define when needed, and
>> there are not a lot of existing uses of it.
>
> Like I said, there's at least four implementations in Emacs of the same
> thing, and who knows how many in 3rd-party packages in ELPA or
> elsewhere. I'm not sure what you consider "a lot," but DRY kicks in
> around three times for me.
For the records, in Tramp I need also this function. I'm just going to
define it myself (derived from eshell-flatten-list), but I'll happily
switch to a common flatten-list.
>> 3. The functions you mention do not all behave
>> the same. Even their arg lists are not the
>> same. (But sure, they could all be made to
>> use a common version, if that were important.)
>>
>> 4. (flatten-list 42) => (42)
>>
>> The doc string says nothing about the case
>> where the argument LIST (a bad name here)
>> is not a list. And if the arg need not be
>> a list then "-list" in the function name
>> is not good.
>
> Right, I didn't mean to imply that the one I sent be added in its
> current state. I just meant to kick off discussion. I basically
> copy/pasted it from somewhere (lpr, I think?). If added it'll need to be
> properly documented and perhaps message-flatten-list and the others made
> obsolete aliases.
Unless nobody else objects, I'd like to encourage you to prepare a patch
to be added to the master branch. This could include the replacement of
the existing implementations.
> Thanks,
> Alex
Thanks, and best regards, Michael.
next prev parent reply other threads:[~2018-12-10 8:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 19:46 bug#33309: Add flatten-list? Alex Branham
2018-11-07 20:36 ` Drew Adams
2018-11-07 21:19 ` Alex Branham
2018-12-10 8:44 ` Michael Albinus [this message]
2018-12-10 17:49 ` Stefan Monnier
2018-12-10 20:12 ` Alex Branham
2018-12-10 21:36 ` Stefan Monnier
2018-12-10 23:06 ` Alex Branham
2018-12-11 12:36 ` Stefan Monnier
2018-12-10 22:42 ` Basil L. Contovounesios
2018-12-10 23:17 ` Alex Branham
2018-12-10 23:26 ` Basil L. Contovounesios
2018-12-10 23:34 ` Stephen Berman
2018-12-11 8:21 ` Michael Albinus
2018-12-11 8:34 ` martin rudalics
2018-12-11 17:36 ` bug#33309: [PATCH] flatten-list Alex Branham
2018-12-11 20:11 ` Michael Albinus
2018-12-11 20:16 ` Alex Branham
2018-12-17 11:33 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736r5ojnc.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=33309@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.