From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.bugs Subject: bug#34065: 26.1; Make edebug-eval-expression support code completion Date: Sat, 19 Jan 2019 23:14:55 -0300 Message-ID: <8736poyt0g.fsf@gmail.com> References: NNTP-Posting-Host: ciao.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ciao.gmane.org 1547950567 250465 195.159.176.228 (20 Jan 2019 02:16:07 GMT) X-Complaints-To: usenet@ciao.gmane.org NNTP-Posting-Date: Sun, 20 Jan 2019 02:16:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) To: Xu Chunyang , 34065@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 20 03:16:05 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1gl2eX-00138x-0r for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Jan 2019 03:16:01 +0100 Original-Received: from localhost ([127.0.0.1]:34197 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gl2ef-0000Kx-OK for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jan 2019 21:16:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gl2eZ-0000KX-Qo for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 21:16:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gl2eY-0004PN-Ov for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 21:16:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38911) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gl2eY-0004OW-KF for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 21:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gl2eY-0002wN-72 for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2019 21:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Federico Tedin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Jan 2019 02:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34065 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 34065-submit@debbugs.gnu.org id=B34065.154795050711227 (code B ref 34065); Sun, 20 Jan 2019 02:16:02 +0000 Original-Received: (at 34065) by debbugs.gnu.org; 20 Jan 2019 02:15:07 +0000 Original-Received: from localhost ([127.0.0.1]:38192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gl2df-0002v1-0k for submit@debbugs.gnu.org; Sat, 19 Jan 2019 21:15:07 -0500 Original-Received: from mail-qk1-f181.google.com ([209.85.222.181]:46922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gl2dd-0002uE-3a for 34065@debbugs.gnu.org; Sat, 19 Jan 2019 21:15:05 -0500 Original-Received: by mail-qk1-f181.google.com with SMTP id q1so10184940qkf.13 for <34065@debbugs.gnu.org>; Sat, 19 Jan 2019 18:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=gSKc8eThsJKmd8r3HuCN8s/LgxwIWipg3SuGPJNMAAQ=; b=U2B/kwTQvF+mPXg/ceSyRfNvrn3Sljwz6qtrzAZaeIduVdPEhZACtIgDOg87SHuvpZ TqA+aCI+/rfTzVro1bhw1EhOFoWCKHTPu5ZqMwfs1lNHcf22tB5km6S8TTNiQ1GX9xxh KhUCowqilrGJwJP4kD259QcQ5P9m3NHSebZFjZCJqEp/9f1NRiCDcCLyQWu9iKrVC5Kt /2hNdE7aSHSGKZnewEneS1QTtq/K1qtsA4T/D8ETEY1WVHLhZSb4JJEK5M9wjQvsSyYz oJ8qr6qNTbiAbL0pzYVGQG6B/rd+HBXHHxP7g8cO8xn7k9jQySF47MwKAM9RR7e+RXeM +eLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=gSKc8eThsJKmd8r3HuCN8s/LgxwIWipg3SuGPJNMAAQ=; b=Q+qOlaQPZ/ZIyRt+eVLWxh5+IF+FpnARieolhHbvvGCEIqJWuDtpWjVdu3gxu5VaLE UxgH+zWVKjAhFHgV+ThLMLbM6lU+kzZHL2nmrvpqrT1lTUkv56fk4YhQCtzbMi/sc/Ot UPvUGP650cBo8B0SZrjwqjFjiJWEaQktxMQHZSGR9TI9OMp+HTGUfSNNTmf+Ky66vJHD rgwJTG50rDs23r7pQBnscD7Z25ILJpYf1N246ZtVFWdlgK0zucqfZ9Rfrl8n6NlopZUN 8Rr4t+gNvq+QAtjZdI7Fch7wqJGsG75lnRCbXiTVsN/J8rieF5S0BK+uM9cf308mJsRG 3clQ== X-Gm-Message-State: AJcUukfRL2lwND1Kxp5GeDkJOJD5Kf2XqIUPGhLZpLJR3NG2wcQN8Ks8 Ekt4Hn1Dq23XswWC6N7Hj+65GDo/ X-Google-Smtp-Source: ALg8bN6A7ToWz0r9SgSYBkZ0W6I0+5T9FCCgYXeKqCiMUEOTvhtMzK1mhNZiTYI2zO0eAbpCGDpFCA== X-Received: by 2002:a37:7347:: with SMTP id o68mr20081866qkc.13.1547950499211; Sat, 19 Jan 2019 18:14:59 -0800 (PST) Original-Received: from hideo ([186.139.31.173]) by smtp.gmail.com with ESMTPSA id a20sm35810626qkj.28.2019.01.19.18.14.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 19 Jan 2019 18:14:58 -0800 (PST) In-Reply-To: (Xu Chunyang's message of "Mon, 14 Jan 2019 17:08:50 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154601 Archived-At: --=-=-= Content-Type: text/plain Xu Chunyang writes: > When type e (edebug-eval-expression) within Edebug, I notice there is no code completion, unlike > M-: (eval-expression). So I wonder if edebug-eval-expression can behave > like eval-expression, I guess simply replacing read-from-minibuffer with > read--expression should work, though I've not tried. I've created a small patch which replaces `read-from-minibuffer' for `read--expression' in `edebug-eval-expression'. I would appreciate it if a maintainer could take a quick look. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=edebug.patch Content-Description: patch >From ce40da7d2b254be1eee5e5f96d674504525f9b72 Mon Sep 17 00:00:00 2001 From: Federico Tedin Date: Sat, 19 Jan 2019 23:02:36 -0300 Subject: [PATCH 1/1] Use read--expression to read expressions in Edebug * lisp/emacs-lisp/edebug.el: Use read--expression instead of read-from-minibuffer to read Emacs Elisp expressions (Bug#34065). --- lisp/emacs-lisp/edebug.el | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index 2cd8e48d6e..8b4cb1adc7 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -3602,9 +3602,7 @@ edebug-eval-expression "Evaluate an expression in the outside environment. If interactive, prompt for the expression. Print result in minibuffer." - (interactive (list (read-from-minibuffer - "Eval: " nil read-expression-map t - 'read-expression-history))) + (interactive (list (read--expression "Eval: "))) (princ (edebug-outside-excursion (setq values (cons (edebug-eval expr) values)) -- 2.17.1 --=-=-=--