From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34974: 27.0.50; Moving article error with duplicate suppression disabled Date: Sun, 24 Mar 2019 14:59:55 +0000 Message-ID: <8736nc2u8k.fsf@tcd.ie> References: <871s2wpedf.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="110225"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eric Abrahamsen , Lars Ingebrigtsen To: 34974@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 24 16:01:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h84cc-000Sa9-KK for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 16:01:14 +0100 Original-Received: from localhost ([127.0.0.1]:57235 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h84cb-0007R9-Kw for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Mar 2019 11:01:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h84cU-0007P3-FS for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:01:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h84cS-0003mI-7N for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:01:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43371) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h84cS-0003mC-26 for bug-gnu-emacs@gnu.org; Sun, 24 Mar 2019 11:01:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h84cR-0004O0-3m; Sun, 24 Mar 2019 11:01:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 24 Mar 2019 15:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34974 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 34974-submit@debbugs.gnu.org id=B34974.155343960513309 (code B ref 34974); Sun, 24 Mar 2019 15:01:02 +0000 Original-Received: (at 34974) by debbugs.gnu.org; 24 Mar 2019 15:00:05 +0000 Original-Received: from localhost ([127.0.0.1]:56909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h84bU-0003SN-TV for submit@debbugs.gnu.org; Sun, 24 Mar 2019 11:00:05 -0400 Original-Received: from mail-ed1-f68.google.com ([209.85.208.68]:43988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h84bT-0003Pl-Qv for 34974@debbugs.gnu.org; Sun, 24 Mar 2019 11:00:04 -0400 Original-Received: by mail-ed1-f68.google.com with SMTP id d26so5381780ede.10 for <34974@debbugs.gnu.org>; Sun, 24 Mar 2019 08:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lkKYVK3uURaNhbkbLP9+T1ZOdSjLSz5gtvjdRovGaF0=; b=tt6ZGFzLr4mYuvLw+ABzSVDdkeb555kDzcv73AC1Y6rZuws9iRyhB6h0bzbhtflftd xxxo7RWERWeCd4n5U2rdgs+cpsrHywzP1u+beVi+sk65ZMFlA28d2RZ0jEKcnjJSTy9h 5OmdP2kTLuDVE8BbXnCSkt6iRbsYyVwfpPGurQeH9YoKQNKu+iswTNNEhz4VLlWi7kUR BWcYmPNlE52ds0fVLhPG+VXv9v4UiTiQbGS8b1cTs8RzML3YFWEQ2SGjzEfJmZg+HOMj Afk/P7Fx+TOznXXWFERLDksrNrVHUPDlew3Xo7Lvcgtkj55MSMpZfCt228sECZcER6AE CR+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lkKYVK3uURaNhbkbLP9+T1ZOdSjLSz5gtvjdRovGaF0=; b=kWnxW/GpRpNH/JF8ATd7LNGrRjkHFygZqYeq32lPJmWszhlLlUYJU4Xe6iCBbAWXT3 cH+6JIeKwU6oNWWdGdQsWqYrg5D6+URlT4kB0bA9eAlzxiUurAfDwVAbT0YnCblPj200 nLSVk3C46+Ud+9oZk3jpzNzQ2DTL9NgaMu0svWZNbj+H1Svj9G0BuXOa0PBeaM1NqXzX VYTnuHnztrfOUPc9p63VzXabqAwkCFXa5R+9oKsOnfSnh7cOMOTcBqWGZPGrzTfw05Za 0nAhsEWclo2N/9hMeWGemfZoJUaXCPrafTOz+GBLws24OHFRbsV6XMFxgex/VsBEuxx6 fHCA== X-Gm-Message-State: APjAAAX/xeDwN9tP6PC5ZeDINQcCk3Al+LKq9xgtECApTbWjaBidLQmA ZLtXtCQqrRCQOZYtH2EQFRTs+bXItQ0VYg== X-Google-Smtp-Source: APXvYqzD9fnpQee3bYZQ1fduAH1uPAHxRjQUStxtBnUcVT4mlgp9RJ6gseI/+wcViHmec84j6XWxqg== X-Received: by 2002:aa7:d954:: with SMTP id l20mr12767242eds.156.1553439597726; Sun, 24 Mar 2019 07:59:57 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id n7sm4248096edq.69.2019.03.24.07.59.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 24 Mar 2019 07:59:57 -0700 (PDT) In-Reply-To: <871s2wpedf.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 24 Mar 2019 14:07:31 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156699 Archived-At: "Basil L. Contovounesios" writes: > With gnus-suppress-duplicates left at its default value of nil, trying > to move an article with 'B m ' gives me the following backtrace: > > Debugger entered--Lisp error: (wrong-type-argument hash-table-p nil) > remhash("" nil) > gnus-dup-unsuppress-article(1988) > gnus-summary-move-article(nil) > funcall-interactively(gnus-summary-move-article nil) > call-interactively(gnus-summary-move-article nil nil) > command-execute(gnus-summary-move-article) > > I'm no expert, and I haven't tried reproducing this with a minimal > config, but I think gnus-summary-move-article should not call > gnus-dup-unsuppress-article when gnus-suppress-duplicates is nil, right? > > This issue seems to have been uncovered by the switch to hash-tables in > bug#33653. Previously, gnus-dup-unsuppress-article called unintern, > which would not complain when its second argument gnus-dup-hashtb was > nil, even though it probably should have. > > Patch to follow. Sorry, this is a duplicate of bug#34973, which was reported first and where I've now sent my suggested patch. I was going to merge the two bug reports, but then I read that the debbugs 'merge' command requires reports to be assigned to the same package. This report was created by the gnus-bug command, which assigned it to both packages emacs and gnus and version 5.13, whereas the other report was presumably created by report-emacs-bug and assigned to the emacs package, version 27.0.50. So, which package+version combination should Gnus bugs be assigned to? How should these two reports be merged? Does merging keep all parties CCed, or do they have to be CCed anew? Thanks, -- Basil