From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#34954: 26.1.92; eshell gets loaded twice Date: Wed, 03 Apr 2019 22:55:09 -0400 Message-ID: <8736myfpiq.fsf@gmail.com> References: <2himw4qz18.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="228645"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) Cc: 34954@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 04 05:10:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBslf-000xNE-5X for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Apr 2019 05:10:19 +0200 Original-Received: from localhost ([127.0.0.1]:41164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBsle-0002C0-3b for geb-bug-gnu-emacs@m.gmane.org; Wed, 03 Apr 2019 23:10:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBsky-0001gV-99 for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 23:09:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBsXq-0007zS-Nj for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 22:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58231) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBsXq-0007xz-ER for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 22:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBsXq-0001Az-8q for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2019 22:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Apr 2019 02:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34954 X-GNU-PR-Package: emacs Original-Received: via spool by 34954-submit@debbugs.gnu.org id=B34954.15543465214462 (code B ref 34954); Thu, 04 Apr 2019 02:56:02 +0000 Original-Received: (at 34954) by debbugs.gnu.org; 4 Apr 2019 02:55:21 +0000 Original-Received: from localhost ([127.0.0.1]:43542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBsXB-00019p-1M for submit@debbugs.gnu.org; Wed, 03 Apr 2019 22:55:21 -0400 Original-Received: from mail-qt1-f178.google.com ([209.85.160.178]:46640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hBsX9-00019X-54; Wed, 03 Apr 2019 22:55:19 -0400 Original-Received: by mail-qt1-f178.google.com with SMTP id z17so1503957qts.13; Wed, 03 Apr 2019 19:55:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=6S5AUHizo4+yqy4jsmiQRNOUxMPMH29AXkdXAmm0jVE=; b=U/JYfbxFhtA/d1irIsPfCMpMBiWDqsnS8g/NgtC+RMowOzUJA3E3b8oXePtsF9NfbK 1so6+rIVwSpVjwWP6jUpXq3JVv3G3B7P8V+anqM45VgqbgxqJArsUkUbimFg2rKO6vRN tKTgvfmvKMp3nM39nr97meF2Iwz2t89SKtWZtvC830O4AUsEMXPuo/eB+wmif/ppBDK/ uge7jd06Qhhf1oJDrcEwNvkte7w9jW1+y54XulOIF3bKU3iGpwCIBfd1ijdgvJ/m9pxK geIki0GI8Al79axk/8ggqIdYkjhSVdq8a0LeOvs2H0KeKGpHvUOxg6S28naim24VwJYf KTdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=6S5AUHizo4+yqy4jsmiQRNOUxMPMH29AXkdXAmm0jVE=; b=UoFuPCn9Xv+l4AuNwlLnbH7jpg+vyRT21Ac3OdBQC6R8qo6vaPXoG2KQIvV4QEBI58 wR73Jn8VOxtuYlOqGsgzeFejcVu8SSn49b6Zud2VFbFNw6B+i8wHerlJCmZ0o0TYio6W ioOILNMO9usmfkLzxjnFs9nXck79O11HqR6UroP1OYUt2LNdQD7BC9+2WwV2POUxXrjI /FBoUW/swau+Ug30I6TRdDTyPUMMvlb4SCprd6QAcbPnrv/KBunkbns7lmd/Ld1zh6Ji k89ETeAuo5fP6ZKWpy5gx6fia9+fv6cJ2wQ3UUn9snaFprH6m4vxMm1fx96wUdKpxsNX RE8w== X-Gm-Message-State: APjAAAXR/VhUrKHcdVZTTkqxiMdDJn8sIuidvNwHwQesZZsPI8njG4Qn h9WpmPa6gRgsQCYpe2qjCF0ATaph X-Google-Smtp-Source: APXvYqwICnRFHvNMrlyYSm/bBNGF29XL6kT+5Rtvk934MuczD9yDFe56sIxo//7tHlXvoBZfBmgR2w== X-Received: by 2002:ac8:2f96:: with SMTP id l22mr3295417qta.258.1554346511834; Wed, 03 Apr 2019 19:55:11 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id y34sm8098760qta.96.2019.04.03.19.55.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Apr 2019 19:55:10 -0700 (PDT) In-Reply-To: (Mauro Aranda's message of "Wed, 27 Mar 2019 10:51:13 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157156 Archived-At: merge 34954 24491 tags 34954 fixed close 34954 27.1 quit Mauro Aranda writes: > > Anyway, my recipe was meant to provide evidence that eshell gets loaded > twice. That still happens, either eshell-load-hook or > with-eval-after-load is used in real code. It would be good to solve > that double loading. That way, either eshell-load-hook (until it is > obsoleted, if it eventually happens) or with-eval-after-load (any order > of execution) can be used. Yep, makes sense, I've pushed your patch [1: 5e55b1b829]. To your question about a better solution, I think it would require a major reorganizing of eshell's code to avoid circular requires, and we already have some prior art where some eshell have the provide at the top, so we may as well go with what you posted. [1: 5e55b1b829]: 2019-04-03 22:47:10 -0400 Avoid recursive load of eshell https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5e55b1b82952a03b704c464e8086d3c41e993a46