From: Noam Postavsky <npostavs@gmail.com>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: 34954@debbugs.gnu.org
Subject: bug#34954: 26.1.92; eshell gets loaded twice
Date: Wed, 03 Apr 2019 22:55:09 -0400 [thread overview]
Message-ID: <8736myfpiq.fsf@gmail.com> (raw)
In-Reply-To: <CABczVwe5vpqBcdw1h2nct7pFE0+d2W2wVqKfO0ZD4LFymy8QYQ@mail.gmail.com> (Mauro Aranda's message of "Wed, 27 Mar 2019 10:51:13 -0300")
merge 34954 24491
tags 34954 fixed
close 34954 27.1
quit
Mauro Aranda <maurooaranda@gmail.com> writes:
>
> Anyway, my recipe was meant to provide evidence that eshell gets loaded
> twice. That still happens, either eshell-load-hook or
> with-eval-after-load is used in real code. It would be good to solve
> that double loading. That way, either eshell-load-hook (until it is
> obsoleted, if it eventually happens) or with-eval-after-load (any order
> of execution) can be used.
Yep, makes sense, I've pushed your patch [1: 5e55b1b829]. To your
question about a better solution, I think it would require a major
reorganizing of eshell's code to avoid circular requires, and we already
have some prior art where some eshell have the provide at the top, so we
may as well go with what you posted.
[1: 5e55b1b829]: 2019-04-03 22:47:10 -0400
Avoid recursive load of eshell
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5e55b1b82952a03b704c464e8086d3c41e993a46
prev parent reply other threads:[~2019-04-04 2:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 15:05 bug#34954: 26.1.92; eshell gets loaded twice Mauro Aranda
2019-03-23 15:14 ` Mauro Aranda
2019-03-27 12:31 ` Glenn Morris
2019-03-27 13:51 ` Mauro Aranda
2019-04-04 2:55 ` Noam Postavsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736myfpiq.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=34954@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.