From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: scratch/X_Typedefs 09c65d6 5/7: Introduce Emacs_GC struct and typedef Date: Wed, 15 May 2019 12:59:28 -0600 Message-ID: <8736lfh7cf.fsf@gmail.com> References: <20190513175241.9359.28585@vcs0.savannah.gnu.org> <20190513175245.1B38320664@vcs0.savannah.gnu.org> <87sgthgjcj.fsf@gmail.com> <87o945ghk9.fsf@gmail.com> <87k1etggnw.fsf@gmail.com> <838sv8an50.fsf@gnu.org> <87bm04hl6u.fsf@gmail.com> <83pnoj8z7t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="261043"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 15 21:10:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQzIl-0015mt-Rz for ged-emacs-devel@m.gmane.org; Wed, 15 May 2019 21:10:55 +0200 Original-Received: from localhost ([127.0.0.1]:41248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQzIk-0006eo-SC for ged-emacs-devel@m.gmane.org; Wed, 15 May 2019 15:10:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQzGq-0005Zt-S7 for emacs-devel@gnu.org; Wed, 15 May 2019 15:08:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hQz7g-0001FF-F9 for emacs-devel@gnu.org; Wed, 15 May 2019 14:59:29 -0400 Original-Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:33030) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hQz7g-0001EO-9C; Wed, 15 May 2019 14:59:28 -0400 Original-Received: by mail-pf1-x42b.google.com with SMTP id z28so453606pfk.0; Wed, 15 May 2019 11:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=g8ZgqlivBj5swWxUbIw22WxHjA4qZWmhWmwQ7u8MH7I=; b=iztxuYrXhjuAJRxNBUI/QSUq6lySKk+VQRhdMR7GkxCm2rd5fo+alWwjFIUfRzoxMV E17Xd1k6yKmLWaJcX+eWOExgk+Bv8b+S+mDQCh7nXYMW3u9Pyq2ZBvrXkDXTjSjapU3v DHmEjaoasV6bwtDnNKG0V0T6ovNEzT20EMQmAw5EMSwHbo7flyj0tkR32bBS5JoEMQDZ lUWLCTfh1XMnmj22JMJTxz2QpPBV3Xf2/FGZHsCuCSTT4dMy3ytPhEiyYgmq11lRuZAs Q2pRNhtNngh7r5uSBO1w6KBRdx37axXI95zwofSStdM3jwPt8xSaWxaqJ3tiHqFYvBs8 bp3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=g8ZgqlivBj5swWxUbIw22WxHjA4qZWmhWmwQ7u8MH7I=; b=sL9H2xOkldREOKbzrxEc1gztmIi9maZPyiVU9peuhZmaI8Mk/9zg1lG6HQtTaCAZBN p8oOjks61ZNKFm9QVEYaAdLUx9sN/2/8wmxAQjQSKeJHbMBpLUF5+YEmJ5/eaELQ+UXu p+5aUfemDl4qE2q/mLQTZQ6VR5xdHF+W+b3Xu346sugqfre4hEQvlK/T8QAEUHsGe4Dx 41xIxMuOH+wH3BjBLxDyxsFrvzfslPqYQIrty5T9bh9NDjDa1LAuNfNMeybx/ypOFMlm phUGYy6uprEW4q8H7sw82h7t6DU2h1mK059waq63v8USATfCpZv5D+duLQ9Z6CKScswg fANA== X-Gm-Message-State: APjAAAXGJ2knCKZ9L/+TenQio4O3prxJTZTlqJBDfuENTz0kdbdWaab8 LNaSB+mw3RiWef4ujk6E90ITSVYF X-Google-Smtp-Source: APXvYqzA+IwXyMjeOeR8WL4UUTGdjS57Qq9cbgf1aVkxDzoIWwn53cxi1E9itMqSk45lqcdmAI8SKg== X-Received: by 2002:a62:1692:: with SMTP id 140mr27220294pfw.166.1557946766657; Wed, 15 May 2019 11:59:26 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id 16sm3711341pfj.151.2019.05.15.11.59.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 11:59:25 -0700 (PDT) In-Reply-To: <83pnoj8z7t.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 May 2019 19:22:14 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::42b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236547 Archived-At: Eli Zaretskii writes: > Thanks, it builds now. > > Regarding the patch, I have only one comment: > >> @@ -1289,7 +1317,7 @@ struct glyph_string >> enum glyph_row_area area; >> >> /* Characters to be drawn, and number of characters. */ >> - XChar2b *char2b; >> + unsigned short *char2b; >> int nchars; > > Why use 'unsigned short' and not 'unsigned int'? The latter is more > efficient on modern architectures, and in structures you will likely > have the compiler pad the following 16 bits anyway. I thought that it would be better to only use a (minimum) 16-bit unsigned if that's all that is needed. If it's more efficient to use unsigned then that's even better, since some loops and alloca calls in, e.g., {x,w32}_compute_glyph_string_overhangs can be removed. I'll change the type to unsigned and merge the branch later if there are no objections.