* bug#35772: 27.0.50; Repeated define-key call in picture.el
@ 2019-05-17 13:04 Mauro Aranda
2019-05-17 13:13 ` Mauro Aranda
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2019-05-17 13:04 UTC (permalink / raw)
To: 35772
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
Hello.
In picture.el (picture-mode-map), there is a repeated call to
define-key, like this:
(define-key map [remap self-insert-command] 'picture-self-insert)
(define-key map [remap self-insert-command] 'picture-self-insert)
Trivial patch to come.
Best regards,
Mauro.
[-- Attachment #2: Type: text/html, Size: 360 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#35772: 27.0.50; Repeated define-key call in picture.el
2019-05-17 13:04 bug#35772: 27.0.50; Repeated define-key call in picture.el Mauro Aranda
@ 2019-05-17 13:13 ` Mauro Aranda
2019-05-20 18:25 ` Noam Postavsky
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2019-05-17 13:13 UTC (permalink / raw)
To: 35772
[-- Attachment #1.1: Type: text/plain, Size: 29 bytes --]
Tags: patch
Patch attached.
[-- Attachment #1.2: Type: text/html, Size: 102 bytes --]
[-- Attachment #2: 0001-Remove-repeated-function-call-in-picture.el.patch --]
[-- Type: text/x-patch, Size: 962 bytes --]
From 4726e9401718e5836d72c0f159f0fed8c2d1c281 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Fri, 17 May 2019 10:00:01 -0300
Subject: [PATCH] Remove repeated function call in picture.el
* lisp/textmodes/picture.el (picture-mode-map): Remove repeated
define-key call. (Bug#35772)
---
lisp/textmodes/picture.el | 1 -
1 file changed, 1 deletion(-)
diff --git a/lisp/textmodes/picture.el b/lisp/textmodes/picture.el
index b520849..bc85372 100644
--- a/lisp/textmodes/picture.el
+++ b/lisp/textmodes/picture.el
@@ -625,7 +625,6 @@ 'picture-delete-char
(defvar picture-mode-map
(let ((map (make-keymap)))
(define-key map [remap self-insert-command] 'picture-self-insert)
- (define-key map [remap self-insert-command] 'picture-self-insert)
(define-key map [remap completion-separator-self-insert-command]
'picture-self-insert)
(define-key map [remap completion-separator-self-insert-autofilling]
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#35772: 27.0.50; Repeated define-key call in picture.el
2019-05-17 13:13 ` Mauro Aranda
@ 2019-05-20 18:25 ` Noam Postavsky
0 siblings, 0 replies; 3+ messages in thread
From: Noam Postavsky @ 2019-05-20 18:25 UTC (permalink / raw)
To: Mauro Aranda; +Cc: 35772
tags 35772 fixed
close 35772 26.3
quit
Mauro Aranda <maurooaranda@gmail.com> writes:
> --- a/lisp/textmodes/picture.el
> +++ b/lisp/textmodes/picture.el
> @@ -625,7 +625,6 @@ 'picture-delete-char
> (defvar picture-mode-map
> (let ((map (make-keymap)))
> (define-key map [remap self-insert-command] 'picture-self-insert)
> - (define-key map [remap self-insert-command] 'picture-self-insert)
Pushed to emacs-26.
eadf044e06 2019-05-20T14:22:58-04:00 "Remove repeated function call in picture.el"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=eadf044e0663703af61967c1ff890043f46c9a15
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-20 18:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-17 13:04 bug#35772: 27.0.50; Repeated define-key call in picture.el Mauro Aranda
2019-05-17 13:13 ` Mauro Aranda
2019-05-20 18:25 ` Noam Postavsky
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.