From: Michael Albinus <michael.albinus@gmx.de>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 36159@debbugs.gnu.org
Subject: bug#36159: [PATCH] auto-revert mode doesn't work when changing buffer file name
Date: Tue, 11 Jun 2019 15:15:19 +0200 [thread overview]
Message-ID: <8736kgjmag.fsf@gmx.de> (raw)
In-Reply-To: <F01A3972-49FA-4152-B2F3-6BA46845D597@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Mon, 10 Jun 2019 18:57:04 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
Hi Mattias,
> Auto-revert mode stops working effectively when the user changes the
> buffer file name, by running `write-file' for example, because the
> notifier still tracks the old file.
>
> The attached patch attempts to rectify this.
LGTM. Two minor nits:
> +(defun auto-revert--set-visited-file-name ()
Since we add it to a hook from another package, it shouldn't be marked
internal. Call it `auto-revert-set-visited-file-name'.
> + (should (equal (buffer-string) "C"))))
> + (ignore-errors (kill-buffer buf))
> + (ignore-errors (delete-file file-1))
> + (ignore-errors (delete-file file-2)))))
In the other tests, we separate the unwindforms from the bodyform (an
empty line, plus a comment). Maybe you could do it here as well.
For me, the last two tests fail in the remote case:
2 unexpected results:
FAILED auto-revert-test05-global-notify-remote
FAILED auto-revert-test06-write-file-remote
Do you want to check, or shall I do it?
Best regards, Michael.
next prev parent reply other threads:[~2019-06-11 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 16:57 bug#36159: [PATCH] auto-revert mode doesn't work when changing buffer file name Mattias Engdegård
2019-06-11 13:15 ` Michael Albinus [this message]
2019-06-11 16:55 ` Mattias Engdegård
2019-06-11 18:02 ` Michael Albinus
2019-06-11 20:17 ` Mattias Engdegård
2019-06-15 9:16 ` Michael Albinus
2019-06-15 9:26 ` Mattias Engdegård
2019-06-15 9:56 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736kgjmag.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=36159@debbugs.gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.