From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#25111: (Inaccurate documentation of inhibit-modification-hooks) Date: Mon, 24 Jun 2019 18:48:14 -0400 Message-ID: <8736jytxap.fsf@gmail.com> References: <20190519203119.GA5309@ACM> <87y32u908k.fsf@gmail.com> <20190525134407.GA10864@ACM> <87sgt28ut4.fsf@gmail.com> <20190527143109.GA5863@ACM> <20190603191549.GA4009@ACM> <85tvd6bhch.fsf@gmail.com> <20190604093241.GA5790@ACM> <838suhto2r.fsf@gnu.org> <83muirarzj.fsf@gnu.org> <20190624125249.GB4781@ACM> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="99322"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 25111@debbugs.gnu.org, phillip.lord@russet.org.uk To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 00:49:52 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfXma-000Pit-6L for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 00:49:52 +0200 Original-Received: from localhost ([::1]:55234 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfXmZ-0004fs-7r for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jun 2019 18:49:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39370) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfXln-000458-Mg for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 18:49:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfXlm-0000TH-KR for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 18:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44713) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfXlm-0000T9-GH for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 18:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfXlm-0000wl-DS for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2019 18:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2019 22:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25111 X-GNU-PR-Package: emacs Original-Received: via spool by 25111-submit@debbugs.gnu.org id=B25111.15614165033557 (code B ref 25111); Mon, 24 Jun 2019 22:49:02 +0000 Original-Received: (at 25111) by debbugs.gnu.org; 24 Jun 2019 22:48:23 +0000 Original-Received: from localhost ([127.0.0.1]:58257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfXl9-0000vH-0f for submit@debbugs.gnu.org; Mon, 24 Jun 2019 18:48:23 -0400 Original-Received: from mail-io1-f51.google.com ([209.85.166.51]:37775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfXl7-0000v0-Nc for 25111@debbugs.gnu.org; Mon, 24 Jun 2019 18:48:22 -0400 Original-Received: by mail-io1-f51.google.com with SMTP id e5so731702iok.4 for <25111@debbugs.gnu.org>; Mon, 24 Jun 2019 15:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pxEamgLbrgseuwE2BjiEuwov1duVqcyvzot8thoB4es=; b=bv+33wuaONVD9xRHkV3RhoLD0pH/yt7PB2MAg9/cESj3hgZ6fcKqTZDaCtef/V4bUH pUkZQPn2N5PAb43ysujmg1xDBcAenVa3MmfdUw06uHH+FNpi+DZJt7ZDtkZ/sZDhf5vq BQiGoejDwMbvN9NtzuDM9Mxw8BHzc3XWCrLsw+eQdOXetr82DfmkC0RycWw/lCLrRmbf PWsfBdevWABq365Ice1YicvdSR/kTl0BVWLGmNU+86lZWWyiQ5wBAyOJshwUDhYgcYPH zQyrrt7fweoLK04ZPHwz/Hkwma7YIjxMH/mcuOEGduXs8wspmtxji7ZsG3Lx3BFzxr6Z f/+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pxEamgLbrgseuwE2BjiEuwov1duVqcyvzot8thoB4es=; b=Qi9chR6ZtVNQuz5FT5+D3q8lScutwZZfczfYo1Lp53lNYd1075BxUkxCljiY9pOY/U KM1v7aXjajkXsGqS4cUSYNKVIe8xhicBmunnR3cEV4qh/YOCvecb9wmkM6OEeFQX9HRn FiZKN7DViqXMus3GbJuKIJ+w7TGxWB4D2LGXelDmh26QDunJJMvsJwfsWC2iuBNDaat1 4H5sAHmTkRpJ+WgZR5XAFlvB2nbfjao/gursu8b29anCaGE5bJkbHZaGovIVig9E8flS 9HuVE0oKD0ZWF3cfMj4lZRvO18w3JTKcaKTjp3NpZvBwWBXFEgJmQiDxru3L9F65G2i7 SrPw== X-Gm-Message-State: APjAAAXqAQmR8TuiYcxjzql6c+VBilpdGEREpLR77sVfH+kHK3OCPgcp eUJLkotn9DUiOoy09twcBMc= X-Google-Smtp-Source: APXvYqxkS31QrzpdaigdFXAl6ybZOQhUcbTHQfz4kSK81vmtrFh55r7FGdR3lsq7A3E01MaBNSTaMA== X-Received: by 2002:a5d:9251:: with SMTP id e17mr16461787iol.21.1561416495858; Mon, 24 Jun 2019 15:48:15 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id f17sm27706465ioc.2.2019.06.24.15.48.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Jun 2019 15:48:15 -0700 (PDT) In-Reply-To: <20190624125249.GB4781@ACM> (Alan Mackenzie's message of "Mon, 24 Jun 2019 12:52:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161293 Archived-At: Alan Mackenzie writes: > Hello, Eli and Noam (but mainly Noam). > > It's about time we finally got this matter tidied up, so... Yeah, sorry I dropped the ball on this. > I think the changes as now formulated are right. Perhaps one or both of > you might like to give the following patch a quick review. Thanks! Minor formatting nitpick: > +++ b/doc/lispref/display.texi > @@ -1752,9 +1752,12 @@ Overlay Properties > +When these functions are called, @code{inhibit-modification-hooks} is > +bound to non-@code{nil}. If the functions modify the buffer, you > +might want to bind @code{inhibit-modification-hooks} to nil, so as to ^^^ > +cause the change hooks to run for these modifications. However, doing > +this may call your own change hook recursively, so be sure to prepare > +for that. @xref{Change Hooks}. > +++ b/doc/lispref/text.texi > @@ -3639,6 +3642,13 @@ Special Properties > beginning and end of the inserted text. The functions are called > @emph{after} the actual insertion takes place. > > +When these functions are called, @code{inhibit-modification-hooks} is > +bound to non-@code{nil}. If the functions modify the buffer, you > +might want to bind @code{inhibit-modification-hooks} to nil, so as to ^^^ @code{nil} for both of these, right? Otherwise looks good to me.