From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to gnus-notifications.el Date: Sun, 21 Jul 2019 15:44:55 +0200 Message-ID: <8736iz7b8o.fsf@mouse.gnus.org> References: <87y30s5hv4.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="222996"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Julien Danjou , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 21 15:45:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpC9K-000vsK-EN for ged-emacs-devel@m.gmane.org; Sun, 21 Jul 2019 15:45:14 +0200 Original-Received: from localhost ([::1]:56128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpC9J-0002yl-BO for ged-emacs-devel@m.gmane.org; Sun, 21 Jul 2019 09:45:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50072) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpC9G-0002vz-5u for emacs-devel@gnu.org; Sun, 21 Jul 2019 09:45:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpC9D-0007jS-7T for emacs-devel@gnu.org; Sun, 21 Jul 2019 09:45:09 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:52706) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpC99-0007fS-Ka for emacs-devel@gnu.org; Sun, 21 Jul 2019 09:45:05 -0400 Original-Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpC92-0004Jl-Ck; Sun, 21 Jul 2019 15:44:59 +0200 In-Reply-To: <87y30s5hv4.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 21 Jul 2019 01:52:31 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238766 Archived-At: "Basil L. Contovounesios" writes: > The following patch for gnus-notifications.el enables lexical-binding > and simplifies and clarifies some of the code and docs. WDYT? Except for what Michael commented about checking for whether notifications are supported, it looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no