From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Improve Gravatar support Date: Mon, 22 Jul 2019 15:31:17 +0200 Message-ID: <8736iy2o2i.fsf@mouse.gnus.org> References: <87muh6w6c6.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="262013"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Julien Danjou , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 22 15:31:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpYPu-0015z0-BQ for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 15:31:50 +0200 Original-Received: from localhost ([::1]:33576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYPn-0003x2-Il for ged-emacs-devel@m.gmane.org; Mon, 22 Jul 2019 09:31:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52045) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hpYPV-0003k5-Cv for emacs-devel@gnu.org; Mon, 22 Jul 2019 09:31:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hpYPU-0002Is-6B for emacs-devel@gnu.org; Mon, 22 Jul 2019 09:31:25 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:42518) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hpYPT-0002Hz-VA for emacs-devel@gnu.org; Mon, 22 Jul 2019 09:31:24 -0400 Original-Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpYPO-0006qu-4m; Mon, 22 Jul 2019 15:31:20 +0200 In-Reply-To: <87muh6w6c6.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 22 Jul 2019 14:23:53 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238784 Archived-At: After skimming (on holiday), looks good to me. Extremely minor comments below: "Basil L. Contovounesios" writes: > (defcustom gnus-gravatar-too-ugly gnus-article-x-face-too-ugly > - "Regexp matching posters whose avatar shouldn't be shown automatically." > - :type '(choice regexp (const nil)) > + "Regexp matching posters whose avatar shouldn't be shown automatically. > +Nil means show all avatars." We don't capitalise nil in documentation, do we? > - ;; The buffer can be gone at this time > - (when (buffer-live-p (current-buffer)) > + ;; The buffer can be gone at this time. > + (when (buffer-name) I think buffer-live-p is clearer than just saying buffer-name. > - (interactive (list t)) ;; When type `W D g' > + (interactive "p") ;; When type `W D g' Perhaps grammer fix? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no