From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: bug#34160: About commit bff64115a0ad081282e0f99305f41c8dd1917d67, bug#34160, json.el Date: Thu, 01 Aug 2019 14:16:02 +0200 Message-ID: <8736iljd31.fsf@gnu.org> References: <87ef26ac17.fsf@gnu.org> <87a7cuvyg3.fsf@mouse.gnus.org> <16c4982bea8.27dc.69bc538c4644581689883e654f15bce0@gnu.org> <87v9vinefd.fsf@mouse.gnus.org> <877e7xjxjj.fsf@gnu.org> <87ef25nns3.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="19386"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34160@debbugs.gnu.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 01 14:16:31 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htA0U-0004vk-Hk for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 14:16:30 +0200 Original-Received: from localhost ([::1]:55412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htA0T-0004tk-G6 for ged-emacs-devel@m.gmane.org; Thu, 01 Aug 2019 08:16:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43234) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htA05-0004rK-P5 for emacs-devel@gnu.org; Thu, 01 Aug 2019 08:16:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1htA05-0006kq-7a; Thu, 01 Aug 2019 08:16:05 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:44723) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1htA04-000589-V4; Thu, 01 Aug 2019 08:16:05 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 8034A21BBF; Thu, 1 Aug 2019 08:16:04 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 01 Aug 2019 08:16:04 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleejgdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgesthdtredttdertdenucfhrhhomhepvfgrshhsihhl ohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucfkphepudefgedrudduledrvd egrdduleehnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgr uhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhh eppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhmnecuvehluhhsthgvrhfuihiivgep td X-ME-Proxy: Original-Received: from jiffyarch (j289989.servers.jiffybox.net [134.119.24.195]) by mail.messagingengine.com (Postfix) with ESMTPA id CCB6F80065; Thu, 1 Aug 2019 08:16:03 -0400 (EDT) In-Reply-To: <87ef25nns3.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Thu, 01 Aug 2019 13:11:24 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239093 Archived-At: Lars Ingebrigtsen writes: >> It can still be a bit improved in understandability and efficiency. >> >> 1. The function passed to replace-region-contents runs on the narrowed >> buffer anyway, so no need to narrow it yourself. >> >> 2. It would be better to create a temporary buffer, json-read repeatedly >> from the original buffer, json-encode/insert to the temp one, and >> then return the temp buffer. >> >> The reason for point 2 is that if the function passed to >> replace-region-contents returns a string, it'll put that in a temporary >> buffer anyhow so that it can use replace-buffer-contents to perform the >> actual replacement (replace-region-contents is just a wrapper around >> that). > > Sounds like a good idea; please go ahead. Will do at the weekend. Bye, Tassilo