From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24649: 24.5; Why no standard error for "Trailing garbage following expression"? Date: Fri, 23 Aug 2019 02:25:37 +0200 Message-ID: <8736hsbuda.fsf@mouse.gnus.org> References: <58b6fb05-499d-4406-9bac-9c0889a588b8@default> <875znnh8if.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1884"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 24649@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 23 02:26:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0xPH-0000LL-9O for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 02:26:19 +0200 Original-Received: from localhost ([::1]:50582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0xPG-0005jX-6Z for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Aug 2019 20:26:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43226) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i0xP1-0005en-7k for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i0xP0-0004da-5z for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58000) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i0xP0-0004dN-35 for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i0xOz-0001qI-VA for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2019 20:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 00:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24649-submit@debbugs.gnu.org id=B24649.15665199447042 (code B ref 24649); Fri, 23 Aug 2019 00:26:01 +0000 Original-Received: (at 24649) by debbugs.gnu.org; 23 Aug 2019 00:25:44 +0000 Original-Received: from localhost ([127.0.0.1]:38585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0xOi-0001pW-Fi for submit@debbugs.gnu.org; Thu, 22 Aug 2019 20:25:44 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0xOg-0001pL-4S for 24649@debbugs.gnu.org; Thu, 22 Aug 2019 20:25:42 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i0xOb-0001tP-L4; Fri, 23 Aug 2019 02:25:41 +0200 In-Reply-To: <875znnh8if.fsf@mouse.gnus.org> (Lars Ingebrigtsen's message of "Sat, 27 Jul 2019 16:11:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165614 Archived-At: Lars Ingebrigtsen writes: > Drew Adams writes: > >> Shouldn't this error be a standard error? If not a new standard error, >> shouldn't it at least use one of the existing standard errors, such as >> `scan-error' or `invalid-read-syntax'? >> >> Otherwise, how to easily handle this error (e.g., to tell the user to >> correct the input being read and then read again)? > > Makes sense to me. I'm not sure what signal to use, though -- anybody > got an idea? [...] > + xsignal1 (Qinvalid_read_syntax, > + build_string ("Trailing garbage following expression")); There weren't any comments, so I've now applied this. If somebody has a better idea for the error signal, please amend. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no