From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#36940: tests slowness and failure after recent Tramp changes Date: Sat, 24 Aug 2019 10:08:22 +0200 Message-ID: <8736hryoi1.fsf@gmx.de> References: <57e233fe-19e9-6eac-7fd5-7e181879d4df@cs.ucla.edu> <87h86uh2l6.fsf@gmx.de> <1bec46f5-01e7-5ea4-5562-501185d80ecf@cs.ucla.edu> <87v9vaf4sk.fsf@gmx.de> <87r25xf1dn.fsf@gmx.de> <8736ibkbne.fsf@gmx.de> <87mughfj96.fsf@gmx.de> <470b50ab-6658-e3cb-cd59-916c398c442f@cs.ucla.edu> <87h86of1tm.fsf@gmx.de> <87v9v0avhm.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="93323"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Paul Eggert , 36940@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 24 10:09:58 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1R7V-000O3L-TR for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Aug 2019 10:09:58 +0200 Original-Received: from localhost ([::1]:36418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1R7U-0000NK-3K for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Aug 2019 04:09:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40096) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1R6d-0000ND-Ux for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 04:09:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1R6c-0006m1-Ic for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 04:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1R6c-0006ln-Aw for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 04:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1R6c-0005hf-3o for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 04:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2019 08:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36940 X-GNU-PR-Package: emacs Original-Received: via spool by 36940-submit@debbugs.gnu.org id=B36940.156663412521898 (code B ref 36940); Sat, 24 Aug 2019 08:09:02 +0000 Original-Received: (at 36940) by debbugs.gnu.org; 24 Aug 2019 08:08:45 +0000 Original-Received: from localhost ([127.0.0.1]:41554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1R6L-0005h8-8v for submit@debbugs.gnu.org; Sat, 24 Aug 2019 04:08:45 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:39665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1R6J-0005gv-MH for 36940@debbugs.gnu.org; Sat, 24 Aug 2019 04:08:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1566634104; bh=VsgudVEvhbFIeigj+g5N4YqA6ZCUN+HZ6HjTg0yrBrM=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=TXoliRYZlnWtpYzfAObsU1Iw/ZUVE3PNMpZ4HpneMf5PGWorGO/yQfewPy+a2dMv5 eW+1tbdKI4RIcz0MAaMF9oaY7vvxuvLXDx44TUopch+316kZshXW6Xd75yed2zz9x7 u86yOMDhBWfrG6CF75LDQa40QeHr97eib60ZBiGk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.91.243.33]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LqylH-1ifhvP1x6x-00efAb; Sat, 24 Aug 2019 10:08:24 +0200 In-Reply-To: (Stefan Kangas's message of "Sat, 24 Aug 2019 03:51:26 +0200") X-Provags-ID: V03:K1:4olK+H68bNA37EJCwf95kbwsNjuH4nmP8oEzuTqn9BmI8g0JOnM pox1G1FDS58rsk21sDzjIY3d2/fGKrhFBc2OFN0noA1YxXz/R7EKjPHR7IlJqyBQ0DqUl5f Ucdyak4Gatifje52Yv+/hAMOJcP2eTsFElZLQXTpyxO1h3SYBmeSb7s4F8cVdoFoeyDE365 btK74NGba51f6Mc6Tx5Gw== X-UI-Out-Filterresults: notjunk:1;V03:K0:arUlaH4kgtQ=:S6zpcsSyLsX5tEobW4dVa0 9ok7cwrE+LE2iFGsqgOupwewgyiBlwGgYACnxyMqu1A22Ld01KKTNPCnG3w6VYfUUUlZOFaML P5tXUMWrXjeiX/VlZqFBlM1l5orxCPrc/0bw0k2gU0wUnFfZg8cREvP2Q/bYSUw1F1YsuMUmq Sz4vHy/tFznr5St60xqp5YFLrmxDeZwLRfPfpFQyZiS2sIc+wAMMwCztzC6yOuwUcggq/xqGo 7f1YIyEWeHYTQ6YhKhooEvcQKJtj9QTS9g5KYJ9/0F2rOgUeS/L3QJBhrJomeY02SEeWIlrlc TYNzapyqY0tmVMwYNc5OF/X/mCIrkVHlM5ZpjItn7mhIwIVnZNu8iWFOEIwvVW03ea70CsGgv 2Tzut8zihyDxu3+EQf1jFhncWtkmsDd3yLfEA3jx8kWvXtOp1J5DP3/Tvz5LrYbs9MvgQcp8R uwwTApXRIbtIX9OTEEMGDkFoajm4YXQTgoYSLivxWs/jyzupLmeIYv8I7CSMrJMMCTFxcCZq/ 7oC05LLHnjmWjvawB5F1MIWY3fFzpqj3164yZrhSGxE++b68FNeBrtNZ3wA1nT0I/SJgqeoed fQaUUzDHgGBm9/zqTB87pIHhMBuds79r9g1CkqZ+uXhu0SVZVD95Q7/q2SjlYCs9cVNfHvXTr IRkbXmVs2kwkQf4AcXI8ZtQa/FPpOQ8fjTFTIU5vtB/ezajgcdkiFVF2NH/5t9WEnsUMixIwo fSpQvFjrPl8rufXiRBIV4dOUsDqIYODmdTUN8CE7XbaHKsUKdSPzoUWe/LrUTrXKck20slSx X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165757 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Kangas writes: > Hi Michael, Hi Stefan, > I'm still seeing failures on my MacOS machine on current master. I > have attached a log with two failing tests from when I run "make > check" in the top level emacs folder as the file tramp-tests.log. > > Weirdly enough, when I say "cd test ; make tramp-tests", I get six > errors instead -- but no log file is saved. Not sure if I'm doing > something wrong here, but I've included the console output from this > test as tramp-tests2.console.log. I tried running the tests in both > ways a couple of times, and this odd result is reproducible every > time. If you say "make check", the default ert selector is applied, which excludes expensive tests. if you say "make FOO", all test from package foo are applied, also the expensive tests. You see it by the different numbers of tests, 47 vs 67 tests. If you want to get a log file when running tests for package FOO, say "make FOO.log". This seems to be broken now; will check. All of this is described in test/README. > (Not sure if you want to reopen the bug report for this.) For the time being, I'll continue to reply here. If needed (more complex failure, not reported initially here) we might need to create another bug report. > (t 3 501 20 (0 0 0 1000) (0 0 0 1000) (0 0 0 1000) 0 "drwxr-xr-x" nil 413= 69843 (-1 . 18)) > (t 5 501 20 (0 0 0 1000) (0 0 0 1000) (0 0 0 1000) 0 "drwxr-xr-x" nil (63= 1 . 16627) (-1 . 18)) > Test tramp-test19-directory-files-and-attributes condition: > (ert-test-failed > ((should > (tramp--test-file-attributes-equal-p > (file-attributes ...) > (cdr elt))) > :form > (tramp--test-file-attributes-equal-p > (t 3 501 20 > (23904 37780) > (23904 37780) > (23904 37780) > 102 "drwxr-xr-x" nil ...) > (t 5 501 20 > (23904 37780) > (23904 37780) > (23904 37780) > 170 "drwxr-xr-x" nil ...)) > :value nil :explanation > (list-elt 1 > (different-atoms > (3 "#x3" "?") > (5 "#x5" "?"))))) > FAILED 30/67 tramp-test19-directory-files-and-attributes (0.996916 s= ec) Well, this time it is because of a different inode number, 41369843 vs (631 . 16627). Will check what's up. > Test tramp-test22-file-times condition: > (ert-test-failed > ((should > (equal > (tramp-compat-file-attribute-modification-time ...) > (seconds-to-time 1))) > :form > (equal > (0 1) > (0 1 0 0)) > :value nil :explanation > (proper-lists-of-different-length 2 4 > (0 1) > (0 1 0 0) > first-mismatch-at 2))) > FAILED 33/67 tramp-test22-file-times (0.567633 sec) Grrr, the time stamps (0 1) and (0 1 0 0) are the same, but handled differently internally. Fixed in master. > Test tramp-test30-make-process condition: > (ert-test-failed > ((should > (string-match "killed > \\'" > (buffer-string))) > :form > (string-match "killed > \\'" "killed: 9 > ") > :value nil)) > FAILED 41/67 tramp-test30-make-process (1.024851 sec) Ahh, the message on macOS is slightly different. Fixed in master. > Test tramp-test41-utf8 condition: > (search-failed "^VAR_971C287AFA5BBEDD54ACB58B1CE718B4=3D=CE=93=CF=85= =CF=81=CE=B9=CC=81=CF=83=CF=84=CE=B5 =CF=84=CE=BF =CE=93=CE=B1=CE=BB=CE=B1= =CE=BE=CE=B9=CC=81=CE=B1 =CE=BC=CE=B5 =CE=A9=CC=81=CF=84=CE=BF =CE=A3=CF=84= =CE=BF=CF=80$") > FAILED 58/67 tramp-test41-utf8 (35.641851 sec) > Test tramp-test41-utf8-with-ls condition: > (search-failed "^VAR_971C287AFA5BBEDD54ACB58B1CE718B4=3D=CE=93=CF=85= =CF=81=CE=B9=CC=81=CF=83=CF=84=CE=B5 =CF=84=CE=BF =CE=93=CE=B1=CE=BB=CE=B1= =CE=BE=CE=B9=CC=81=CE=B1 =CE=BC=CE=B5 =CE=A9=CC=81=CF=84=CE=BF =CE=A3=CF=84= =CE=BF=CF=80$") > FAILED 59/67 tramp-test41-utf8-with-ls (29.942527 sec) > Test tramp-test41-utf8-with-perl condition: > (search-failed "^VAR_971C287AFA5BBEDD54ACB58B1CE718B4=3D=CE=93=CF=85= =CF=81=CE=B9=CC=81=CF=83=CF=84=CE=B5 =CF=84=CE=BF =CE=93=CE=B1=CE=BB=CE=B1= =CE=BE=CE=B9=CC=81=CE=B1 =CE=BC=CE=B5 =CE=A9=CC=81=CF=84=CE=BF =CE=A3=CF=84= =CE=BF=CF=80$") > FAILED 60/67 tramp-test41-utf8-with-perl (36.502001 sec) These three errors are basically the same. Could you please apply the following patch to tramp-tests.el, and show me the output? You might run make -C test tramp-tests >tramp-tests.log 2>&1 --=-=-= Content-Type: text/x-diff Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el index 180f746c64..42d44f780b 100644 =2D-- a/test/lisp/net/tramp-tests.el +++ b/test/lisp/net/tramp-tests.el @@ -5459,7 +5459,8 @@ tramp--test-utf8 (skip-unless (not (tramp--test-windows-nt-and-batch))) (skip-unless (not (tramp--test-windows-nt-and-pscp-psftp-p))) - (tramp--test-utf8)) + (tramp--test-instrument-test-case 10 + (tramp--test-utf8))) (ert-deftest tramp-test41-utf8-with-stat () "Check UTF8 encoding in file names and file contents. --=-=-= Content-Type: text/plain > Thanks, > Stefan Kangas Best regards, Michael. --=-=-=--