From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' Date: Sun, 25 Aug 2019 07:47:02 +0200 Message-ID: <8736hpajah.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="16286"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 15682@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 25 07:48:34 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1lOD-00046P-Qm for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 07:48:33 +0200 Original-Received: from localhost ([::1]:40944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1lOC-0006BG-5X for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 01:48:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53413) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1lNj-0006Ax-Um for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:48:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1lNi-0008MV-Ok for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34642) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1lNi-0008MN-Kq for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1lNi-0008N5-HW for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 01:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 05:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15682 X-GNU-PR-Package: emacs Original-Received: via spool by 15682-submit@debbugs.gnu.org id=B15682.156671202831217 (code B ref 15682); Sun, 25 Aug 2019 05:48:02 +0000 Original-Received: (at 15682) by debbugs.gnu.org; 25 Aug 2019 05:47:08 +0000 Original-Received: from localhost ([127.0.0.1]:43463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1lMq-00087E-8F for submit@debbugs.gnu.org; Sun, 25 Aug 2019 01:47:08 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:57834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1lMo-00085d-C1 for 15682@debbugs.gnu.org; Sun, 25 Aug 2019 01:47:06 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1lMk-0001XY-L7; Sun, 25 Aug 2019 07:47:05 +0200 In-Reply-To: (Mauro Aranda's message of "Fri, 23 Aug 2019 17:41:45 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165800 Archived-At: Mauro Aranda writes: > The attached patch tries to fix this bug, while trying to not change > too much of the code of the widget library. It introduces a keymap > for the link widgets, and only binds mouse-2 events. Since > widget-button-click isn't changed, it has to bind down-mouse-2 too. > In this fix, I also have been careful to not reintroduce bugs that > have come up by changing the keybindings in the widget-keymap, such as > here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23571 I think this makes sense. > I investigated the emacs sources, and have noticed that this patch could cause > problems with three pieces of code: Would it be possible for you to come up with patches for fixing these three pieces, too? And then we could apply all four patches at the same time and not break anything. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no